Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

fix: removing reconciliation status #77

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Nov 16, 2023

Description

Note that I'm avoiding updating the validation controller here since #66 this PR deletes it altogether.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Skarlso Skarlso requested review from phoban01 and souleb November 16, 2023 08:35
@Skarlso Skarlso force-pushed the fix-deleting-reconiling-state branch from 2c7eb8d to 80a809b Compare November 16, 2023 11:16
@Skarlso Skarlso force-pushed the fix-deleting-reconiling-state branch from 02f70f9 to 0f6826e Compare November 17, 2023 13:16
@Skarlso Skarlso force-pushed the fix-deleting-reconiling-state branch from 0f6826e to e9a0fc8 Compare November 17, 2023 13:18
@Skarlso Skarlso merged commit 19baa80 into main Nov 17, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants