refactor: import dataclasses from cc-utils / pipeline-template #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocm-ci-robot-0
added
reviewed/ok-to-test
This comment was marked as outdated.
This comment was marked as outdated.
|
/unhold |
ccwienk
added a commit
to gardener/cc-utils
that referenced
this pull request
Dec 6, 2024
ccwienk
added a commit
to gardener/cc-utils
that referenced
this pull request
Dec 6, 2024
Prepare making github-package to be easier to consume outside Gardener-CICD-Pipeline-Template. Hence mv shared dataclass (GithubIssueTemplateCfg) into (transient) module github.issue (the latter will be resolved after fully migrating github.compliance and friends to delivery-service-repository. see: open-component-model/delivery-service#282
zkdev
reviewed
Dec 9, 2024
Reduce dependencies from delivery-service-repository towards cc-utils (in particular such dependenceis against cc-util's pipeline-template). As GithubIssueTemplateCfg is quite a trivial datastructure, copy it for now (will be deduplicated again by planned mv of upstream github.compliance-package - which is currently blocked by remaining, pipeline-based scans (CX + OS-id), yet to be migrated into ocm-gear-extensions). LicenseCfg was not longer used within cc-utils.
ccwienk
force-pushed
the
refactor-dependencies
branch
from
7ebdcf9 to
3466f90
Compare
ocm-ci-robot-0
added
reviewed/ok-to-test
ccwienk
added a commit
to gardener/cc-utils
that referenced
this pull request
Dec 9, 2024
ccwienk
added a commit
to gardener/cc-utils
that referenced
this pull request
Dec 9, 2024
Prepare making github-package to be easier to consume outside Gardener-CICD-Pipeline-Template. Hence mv shared dataclass (GithubIssueTemplateCfg) into (transient) module github.issue (the latter will be resolved after fully migrating github.compliance and friends to delivery-service-repository. see: open-component-model/delivery-service#282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce dependencies from delivery-service-repository towards cc-utils (in particular such dependenceis against cc-util's pipeline-template).
As GithubIssueTemplateCfg is quite a trivial datastructure, copy it for now (will be deduplicated again by planned mv of upstream github.compliance-package - which is currently blocked by remaining, pipeline-based scans (CX + OS-id), yet to be migrated into ocm-gear-extensions).
LicenseCfg was not longer used within cc-utils.