Idefics3 Addition #379
Merged
Idefics3 Addition #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Sounds good to me, it's possible that there's nothing to change indeed. Because there are small discrepancies between generating with our internal codebase and Transformers integration, please ping me if the scores differ significantly from the officially reported ones |
|
@HugoLaurencon : Yes the changes are only to load the new model version of Idefics3 via config and re-use same style of inference as in Idefics2, other aspects remains constant. |
shan23chen
pushed a commit
to shan23chen/VLMEvalKit
that referenced
this pull request
Oct 3, 2024
* VILA added * Update README.md * resolve config merge conflict * Fix error on Idefics for longer prompt * Fix naming convention to make consistent with Idefics2 and better readability * update config for idefics * Make LLava consistent as well * Add VILA 1.5 3B * Add VILA 1.5 3B * fix naming convention to be similar to the HF models * Multi-Turn added for Phi3-Vision and tested with MMDU * Add multi turn for Intern VL * fix formatting * Add Idefics3 Config * Warning message to build from source --------- Co-authored-by: aamita <aamita@sdg-slurm-bm-gpu-b4-8-ad3-009.compute.sdgdevvcn.oraclevcn.com> Co-authored-by: Junming Yang <[email protected]> Co-authored-by: Haodong Duan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idefics 3 follows same pattern as Idefics2.
Building HF from the Source Code and huggingface/transformers#32473 enables Idefics3
The model has been tested with the transformers library