✨ support add-on agent resource requirements settings #354
Conversation
|
/hold |
| // +optional | ||
| // +listType=map | ||
| // +listMapKey=containerID | ||
| AgentResources []ContainerResourceRequirements `json:"agentResources,omitempty"` |
There was a problem hiding this comment.
maybe just ResourceRequirements
There was a problem hiding this comment.
ResourceRequirements is fine with me.
|
|
||
| // ContainerResourceRequirements defines resources required by one or a group of containers. | ||
| type ContainerResourceRequirements struct { | ||
| // ContainerID is a unique identifier for an agent container. It consists of three parts: resource kind, |
There was a problem hiding this comment.
is this kind or resource type? e.g. should user use Deployment or deployments?
There was a problem hiding this comment.
It's resource kind, such as Deployment. Of course, it could be resource type as well. Which one is better?
There was a problem hiding this comment.
it is better if it is group resource or group kind. Group might be needed since kind or resource names could be the same. Or alternatively, we only support certain type of resources.
There was a problem hiding this comment.
Updated the validation pattern to limit the supported resource types.
| // multiple containers. For example, '*:*:*' matches all containers of the agent. | ||
| // +required | ||
| // +kubebuilder:validation:Required | ||
| // "+kubebuilder:validation:Pattern=`^.+:.+:.+$` |
There was a problem hiding this comment.
does this work with the begining of "?
There was a problem hiding this comment.
The validation here is not strict. A value, like ":abc:def is allowed.
Signed-off-by: Yang Le <[email protected]>
elgnay
force-pushed
the
addon-agent-res-setting
branch
from
0548fc4 to
3e993dc
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elgnay, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-bot
bot
merged commit 1a5e25a
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #