Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure on ppc and pip chk failure on x86 #11

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

ArchanaShinde1
Copy link

@ArchanaShinde1 ArchanaShinde1 commented Feb 27, 2024

Checklist before submitting

Description

Build failure observed on ppc, where apache-beam has build time dependency on 'grpcio' and it pulls third party library as 'boringssl'. Fails on the following error
third_party/boringssl-with-bazel/src/include/openssl/target.h:74:2: error: #error "Unknown target CPU"

Fixes # (issue).
Fixed it by downgrading grpcio to v1.53.0 which uses older version of boringssl that supports PPC systems.
pip check will fail now on apache-beam 2.53.0 has requirement grpcio==1.53.0, but you have grpcio 1.54.3, due to this grpcio change, hence disabling pip check in the recipe

Review process to land

  1. All tests and other checks must succeed.
  2. At least one maintainer must review and approve.
  3. If any maintainer requests changes, they must be addressed.

@ArchanaShinde1 ArchanaShinde1 changed the title Update patch Fix build failure on ppc and pip chk failure on x86 Feb 27, 2024
@ArchanaShinde1 ArchanaShinde1 merged commit e2f218c into open-ce:main Feb 28, 2024
1 of 2 checks passed
@ArchanaShinde1 ArchanaShinde1 deleted the 1fix-pipchk branch February 28, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants