Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seeding dynamic and associated initialisation logic (super-droplet injection during simulation) #1367

Merged
merged 48 commits into from
Sep 14, 2024
Merged

Seeding dynamic and associated initialisation logic (super-droplet injection during simulation) #1367

merged 48 commits into from
Sep 14, 2024

Commits on Aug 17, 2024

  1. first try at adding a Seeding dynamic

    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    646286c View commit details
    Browse the repository at this point in the history

  2. moving contents of test_seeding into a Jupyter notebook, descretisati… 

    …on refactor, parallel=False for seeding backend method
    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    6c22296 View commit details
    Browse the repository at this point in the history

  3. addressing pylint hints

    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    560d2b9 View commit details
    Browse the repository at this point in the history

  4. import reorder

    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    8f10d80 View commit details
    Browse the repository at this point in the history

  5. add seeding to examples_tests conftest.py

    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    3ce815f View commit details
    Browse the repository at this point in the history

  6. fix import warning

    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    3a2a870 View commit details
    Browse the repository at this point in the history

  7. import reorder

    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    04cf0ee View commit details
    Browse the repository at this point in the history

  8. compatibility fix with PySDM v2.71

    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    eb09a71 View commit details
    Browse the repository at this point in the history

  9. callable suped_droplet_injection_rate instead of time_window + sd_cou… 

    …nt plot in the seeding hello world notebook
    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    29bca2a View commit details
    Browse the repository at this point in the history

  10. seeding/no seeding plot

    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    4ec6978 View commit details
    Browse the repository at this point in the history

  11. addressing pylint hints

    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    f0eea06 View commit details
    Browse the repository at this point in the history

  12. add unit test for seeding

    @slayoo
    claresinger authored and slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    3f66e1e View commit details
    Browse the repository at this point in the history

  13. move seeding test to smoke tests

    @slayoo
    claresinger authored and slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    04ec98f View commit details
    Browse the repository at this point in the history

  14. refactor the seeding parcel-based smoke test into a box-based not-so-… 

    …unit unit test
    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    d3318e6 View commit details
    Browse the repository at this point in the history

  15. pylint hints

    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    1f05941 View commit details
    Browse the repository at this point in the history

  16. plot=False

    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    a2bd158 View commit details
    Browse the repository at this point in the history

  17. asserts on sd_num values

    @slayoo
    slayoo committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    bdca44b View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. improve test coverage

    @slayoo
    slayoo committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bd9677e View commit details
    Browse the repository at this point in the history

  2. avoid division by zero in test

    @slayoo
    slayoo committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    47616e1 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. fix output logic

    @slayoo
    slayoo committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    dd042a8 View commit details
    Browse the repository at this point in the history

  2. disable multi-threading for a parcel env

    @slayoo
    slayoo committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    bb4de82 View commit details
    Browse the repository at this point in the history

  3. add rain water mixing ratio product and tst for its values in a smoke… 

    … test
    @slayoo
    slayoo committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    61d4df0 View commit details
    Browse the repository at this point in the history

  4. precommit

    @slayoo
    slayoo committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e427886 View commit details
    Browse the repository at this point in the history

  5. added seeded particle sampling logic (i.e. user performs sampling, dy… 

    …namic performs shuffling from the sampled multiplicities and attribute values), more tests needed, dome TODOs remain
    @slayoo
    slayoo committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c17f338 View commit details
    Browse the repository at this point in the history

  6. precommit

    @slayoo
    slayoo committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9f42bc3 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. use discretise_multiplicities in seeding setup; pylint hints

    @slayoo
    slayoo committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    569a3fa View commit details
    Browse the repository at this point in the history

  2. TODO label, pylint-disable comment

    @slayoo
    slayoo committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0642e96 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. add notebook and test for notebook of parcel simulation without colli… 

    …sions and with or without seeding
    claresinger committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    5e5b775 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. pylint

    claresinger committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    eadebc5 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. pylint notebook

    claresinger committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5c4c52f View commit details
    Browse the repository at this point in the history

  2. add TODO note about shuffle

    claresinger committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9520ab1 View commit details
    Browse the repository at this point in the history

  3. add blank new unit test for particle injection logic

    claresinger committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1a9238e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. add flag for enable_collisions in seeding example and remove duplicat… 

    …e simulation.py file
    claresinger committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    fc4f49e View commit details
    Browse the repository at this point in the history

  2. unit test for number_of_super_particles_to_inject and add ValueError … 

    …in particulator to avoid segfault on injection logic
    claresinger committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    859ce39 View commit details
    Browse the repository at this point in the history

  3. add test for seeded particle index and fix injection logic to iterate… 

    … forward, not backward
    claresinger committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    274a70e View commit details
    Browse the repository at this point in the history

  4. move backend tests to backends/. add test for seeding dynamic includi… 

    …ng shuffle. update todos.
    claresinger committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d19057f View commit details
    Browse the repository at this point in the history

  5. pylint fixes. disable unused-argument for the MockParticulator seedin… 

    …g method in unit tests to retain similarity to real code.
    claresinger committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0dff888 View commit details
    Browse the repository at this point in the history

  6. add edge case of all nan to discretise_multiplicities and add test to… 

    … cover this case
    claresinger committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e2bd0a4 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. replace pytest.mark.xfail with pytest.raises to check for exception t… 

    …ype and message
    @slayoo
    slayoo committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a1b988d View commit details
    Browse the repository at this point in the history

  2. remove comments which just repeat function names

    @slayoo
    slayoo committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    53fbae4 View commit details
    Browse the repository at this point in the history

  3. adding test for attr update marks

    @slayoo
    slayoo committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b799972 View commit details
    Browse the repository at this point in the history

  4. adding test for no-seeds-available error condition

    @slayoo
    slayoo committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    773408b View commit details
    Browse the repository at this point in the history

  5. precommit run

    @slayoo
    slayoo committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d20c69a View commit details
    Browse the repository at this point in the history

  6. addressing pylint comments

    @slayoo
    slayoo committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    67f603d View commit details
    Browse the repository at this point in the history

  7. make precommit ignor long lambda line

    @slayoo
    slayoo committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0d58b70 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. silence pylint

    @slayoo
    slayoo committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    37ea0a0 View commit details
    Browse the repository at this point in the history

  2. two more pylint disable comments

    @slayoo
    slayoo committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    d305e95 View commit details
    Browse the repository at this point in the history

  3. try moving seeding to multi_process_a - there are timeouts on windows… 

    … in multi_process_b now
    @slayoo
    slayoo committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    794243c View commit details
    Browse the repository at this point in the history