Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comparison data format for dJ/Azimi example #1341

Open
wants to merge 71 commits into
base: main
Choose a base branch
from

Conversation

edejong-caltech
Copy link
Collaborator

Updates the jupyter notebooks to use netcdf file output (generated from Cloudy.jl) rather than a python script.

edejong-caltech and others added 30 commits October 14, 2022 16:06
@slayoo
Copy link
Member

slayoo commented Jun 15, 2024

@edejong-caltech the box.ipynb notebook has been commited with some errors in the output, hence devops_tests complain:

FAILED tests/devops_tests/test_notebooks.py::test_no_errors_or_warnings_in_output[examples/PySDM_examples/deJong_Azimi/box.ipynb] - AssertionError: /Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/python3.9/site-packages/xarray/backends/plugins.py:65: RuntimeWarning: Engine 'rasterio' loading failed:
dlopen(/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/python3.9/site-packages/rasterio/_base.cpython-39-darwin.so, 0x0002): Library not loaded: @rpath/libpoppler.91.dylib
  Referenced from: <0B63E196-8B06-333E-89EA-5BB2851BB4E2> /Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libgdal.26.dylib
  Reason: tried: '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/python3.9/site-packages/rasterio/../../../libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/lib/python3.9/site-packages/rasterio/../../../libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/bin/../lib/libpoppler.91.dylib' (no such file), '/Users/emilydejong/opt/anaconda3/envs/edjPySDM/bin/../lib/libpoppler.91.dylib' (no such file), '/usr/local/lib/libpoppler.91.dylib' (no such file), '/usr/lib/libpoppler.91.dylib' (no such file, not in dyld cache)
  warnings.warn(f"Engine {name!r} loading failed:\n{ex}", RuntimeWarning)

Also, there are some pylint errors from test_box.py:


tests/smoke_tests/box/dejong_azimi/test_box.py:47:21: E1101: Module 'PySDM_examples.deJong_Azimi' has no 'cloudy_data_0d' member (no-member)
tests/smoke_tests/box/dejong_azimi/test_box.py:49:12: E1101: Module 'PySDM_examples.deJong_Azimi' has no 'cloudy_data_0d' member (no-member)
tests/smoke_tests/box/dejong_azimi/test_box.py:50:14: E1101: Module 'PySDM_examples.deJong_Azimi' has no 'cloudy_data_0d' member (no-member)
tests/smoke_tests/box/dejong_azimi/test_box.py:81:21: E1101: Module 'PySDM_examples.deJong_Azimi' has no 'cloudy_data_0d' member (no-member)
tests/smoke_tests/box/dejong_azimi/test_box.py:83:12: E1101: Module 'PySDM_examples.deJong_Azimi' has no 'cloudy_data_0d' member (no-member)
tests/smoke_tests/box/dejong_azimi/test_box.py:84:14: E1101: Module 'PySDM_examples.deJong_Azimi' has no 'cloudy_data_0d' member (no-member)

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.66%. Comparing base (1a15de0) to head (1d00ea0).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1341      +/-   ##
==========================================
- Coverage   83.66%   83.66%   -0.01%     
==========================================
  Files         364      364              
  Lines        8939     8938       -1     
==========================================
- Hits         7479     7478       -1     
  Misses       1460     1460              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants