Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new examples & smoke tests: Gedzelman & Arnold 1994 fig 2, Miyake et al. 1968 fig 19; isotope diffusivity ratios in Formulae (Graham's law; Stewart 1975; Hellmann & Harvey); isotope relaxation timescales formulae (Miyake); new ventilation test based on Kinzer & Gunn 1951 table 1; null refactor in Formulae; access to RogersYau terminal vel. from Formulae #1307

Merged
merged 53 commits into from
Apr 27, 2024
Merged

new examples & smoke tests: Gedzelman & Arnold 1994 fig 2, Miyake et al. 1968 fig 19; isotope diffusivity ratios in Formulae (Graham's law; Stewart 1975; Hellmann & Harvey); isotope relaxation timescales formulae (Miyake); new ventilation test based on Kinzer & Gunn 1951 table 1; null refactor in Formulae; access to RogersYau terminal vel. from Formulae #1307

merged 53 commits into from
Apr 27, 2024

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Mar 29, 2024

No description provided.

@slayoo slayoo changed the title Gedzelman & Arnold 1994 example: first draft of fig 2 notebook Gedzelman & Arnold 1994 example: diffusivity ratios in constants_default; fig 2 notebook + smoke test Apr 2, 2024
@slayoo slayoo changed the title Gedzelman & Arnold 1994 example: diffusivity ratios in constants_default; fig 2 notebook + smoke test Gedzelman & Arnold 1994 example: diffusivity ratios in constants_defaults; fig 2 notebook + smoke test Apr 2, 2024
@slayoo slayoo changed the title Gedzelman & Arnold 1994 example: diffusivity ratios in constants_defaults; fig 2 notebook + smoke test Gedzelman & Arnold 1994 example: fig 2 notebook + smoke test; diffusivity ratios in Formulae (Graham's law; Stewart 1975; Hellmann & Harvey) Apr 9, 2024
@slayoo slayoo force-pushed the new_example_gedzelman_arnold branch 2 times, most recently from e76739b to 1c6b2a1 Compare April 14, 2024 17:23
@slayoo slayoo changed the title Gedzelman & Arnold 1994 example: fig 2 notebook + smoke test; diffusivity ratios in Formulae (Graham's law; Stewart 1975; Hellmann & Harvey) new examples & smoketests: Gedzelman & Arnold 1994 fig 2, Miyake et al. 1968 fig 19; isotope diffusivity ratios in Formulae (Graham's law; Stewart 1975; Hellmann & Harvey); isotope relaxation timescales formulae (Miyake); constant fix in GrabowskiEtAl2011 diffusion thermics; new ventilation test based on Kinzer & Gunn 1951 table 1; null refactor in Formulae; access to RogersYau terminal vel. from Formulae Apr 15, 2024
@slayoo slayoo changed the title new examples & smoketests: Gedzelman & Arnold 1994 fig 2, Miyake et al. 1968 fig 19; isotope diffusivity ratios in Formulae (Graham's law; Stewart 1975; Hellmann & Harvey); isotope relaxation timescales formulae (Miyake); constant fix in GrabowskiEtAl2011 diffusion thermics; new ventilation test based on Kinzer & Gunn 1951 table 1; null refactor in Formulae; access to RogersYau terminal vel. from Formulae new examples & smoke tests: Gedzelman & Arnold 1994 fig 2, Miyake et al. 1968 fig 19; isotope diffusivity ratios in Formulae (Graham's law; Stewart 1975; Hellmann & Harvey); isotope relaxation timescales formulae (Miyake); constant fix in GrabowskiEtAl2011 diffusion thermics; new ventilation test based on Kinzer & Gunn 1951 table 1; null refactor in Formulae; access to RogersYau terminal vel. from Formulae Apr 15, 2024
@slayoo
first draft of fig 2 notebook
7bac30d
@slayoo
wip on the notebook
0f9d1ed
@slayoo
moved D/D' to derived-constants calc; added test vs. Horita et al. 20…
c2d990b 
…08; added O-18 case in the notebook, still many TODOs...
@slayoo
b_multiplier
922a234
@slayoo
sorted out the bissing b multiplier (error in the paper); added smoke…
9a2273a 
… test
@slayoo
addressing pylint hints
8129a47
@slayoo
isotope diffusivity ratio formulae: Grahams law, Stewart 1975, Hellma…
ef019ec 
…nn and Harvey 2020
@slayoo
G&A plots for other temperatures, isotopes and deltas ; one new TODO …
f26210f 
…label
@slayoo
oxygen plots for deltas computed using excesses
f5c51f4
@slayoo
remove commented code
0aa03ba
@slayoo
use the new plus-separated Formulae ctor args
a63ccf1
@slayoo
refactor terminal velocity making it usable also from within Formulae
21565fd
@slayoo
share null variants in formulae
a6e28c7
@slayoo
add new unit test for ventillation coefficient based on table 1 from …
2de7e3c 
…Kinzer & Gunn 1951
@slayoo
docstring update
176a1ad
@slayoo
add isotope_relaxation_timescale physics module with Miyake et al. 19…
71860be 
…68 tau
@slayoo
fix error reporting logic in formulae._pick
6591416
@slayoo
add new example: Miyake et al. 1968
5324efe
@slayoo
fix names and one value in GrabowskiEtAl2011 diffusion thermics const…
6d2f842 
…ants
@slayoo
remove unused import
8dbf3cd
@slayoo
cover new pick logic with test
b02a37b
@slayoo
silence pylint
279c13b
@slayoo
pylint hints
6b4e147
@slayoo
fixing circular import again
779a85e
@slayoo
fixing circular import again...?
65be859
@slayoo
todo labels, separate pip-install action steps to facilitate debugging
fca2a88
@slayoo
missing files!
2203948
@slayoo
additional CI ver req
b5e0307
@slayoo
typo fix
51c9114
@slayoo
pylint
8995304
@slayoo
try workarounding pip install issues
5f09914
@slayoo
basic smoke test for Miyake et al. example
5af9518
@slayoo
ddressing pylint hints in notebook
b50145d
@slayoo
addressing more pylint hints in notebook
b129d52
@slayoo
more pylint hints
dff75d1
@slayoo
var renames
2a712bd
@slayoo
add power-series terminal velocity formulae file
3b0185c
@slayoo
add Miyake example to conftest list
1aecd4f
@slayoo
fix G&A smoke test
4321721
@slayoo
pylint
e5d1747
@slayoo
extend timeout for tests to 45 min. to avoid timeouts on windows
3280920
@slayoo
add an assert to isotope diffusivity unit test (just checking the ran…
ab0e7b9 
…ge of values)
@slayoo
add docstring for diffusion temperature-dependence constants
9e38b7d
@slayoo
readme entry for Miyake et al. 1968
7cc3f33
@slayoo
add badges to Miyake fig 3 notebook
e1a3cdc
@slayoo
diffusivity ratios used in Miyake example
c327e26
@slayoo
G&A notebook cleanup
4bbd00f
@slayoo slayoo force-pushed the new_example_gedzelman_arnold branch from 21bb3c7 to 4bbd00f Compare April 27, 2024 15:23
@slayoo slayoo marked this pull request as ready for review April 27, 2024 15:32
@slayoo slayoo changed the title new examples & smoke tests: Gedzelman & Arnold 1994 fig 2, Miyake et al. 1968 fig 19; isotope diffusivity ratios in Formulae (Graham's law; Stewart 1975; Hellmann & Harvey); isotope relaxation timescales formulae (Miyake); constant fix in GrabowskiEtAl2011 diffusion thermics; new ventilation test based on Kinzer & Gunn 1951 table 1; null refactor in Formulae; access to RogersYau terminal vel. from Formulae new examples & smoke tests: Gedzelman & Arnold 1994 fig 2, Miyake et al. 1968 fig 19; isotope diffusivity ratios in Formulae (Graham's law; Stewart 1975; Hellmann & Harvey); isotope relaxation timescales formulae (Miyake); new ventilation test based on Kinzer & Gunn 1951 table 1; null refactor in Formulae; access to RogersYau terminal vel. from Formulae Apr 27, 2024
@slayoo slayoo merged commit 9be3936 into open-atmos:main Apr 27, 2024
140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@slayoo