Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numba backend cached property refactor (tests may compile slower since JIT cache is now local to backend instance) #1299

Merged
merged 24 commits into from
Jun 3, 2024

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Mar 16, 2024

No description provided.

@slayoo slayoo force-pushed the numba_backend_cached_property_refactor branch from ac25cec to 2bf5b80 Compare March 16, 2024 23:21
@slayoo slayoo changed the title Numba backend cached property refactor Numba backend cached property refactor (as of now, introduces a huge performance loss) Mar 17, 2024
@slayoo slayoo force-pushed the numba_backend_cached_property_refactor branch from ce851d0 to f9a3b52 Compare March 23, 2024 12:47
@slayoo slayoo closed this Apr 14, 2024
@slayoo slayoo reopened this Apr 14, 2024
@slayoo slayoo force-pushed the numba_backend_cached_property_refactor branch from b6ffc92 to 5503b1e Compare May 12, 2024 14:33
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 86.71756% with 87 lines in your changes are missing coverage. Please review.

Project coverage is 83.64%. Comparing base (c2b4850) to head (29b4dfd).
Report is 2 commits behind head on main.

Files Patch % Lines
...ckends/impl_numba/methods/fragmentation_methods.py 66.34% 70 Missing ⚠️
PySDM/backends/impl_numba/methods/pair_methods.py 89.13% 10 Missing ⚠️
...SDM/backends/impl_numba/methods/moments_methods.py 91.66% 3 Missing ⚠️
.../backends/impl_numba/methods/collisions_methods.py 98.54% 2 Missing ⚠️
...ackends/impl_numba/methods/displacement_methods.py 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
+ Coverage   83.47%   83.64%   +0.16%     
==========================================
  Files         362      364       +2     
  Lines        8868     8932      +64     
==========================================
+ Hits         7403     7471      +68     
+ Misses       1465     1461       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo slayoo force-pushed the numba_backend_cached_property_refactor branch from b97b088 to 7ae0289 Compare May 31, 2024 20:54
@slayoo slayoo changed the title Numba backend cached property refactor (as of now, introduces a huge performance loss) Numba backend cached property refactor (tests may compile slower since JIT cache is now local to backend instance) Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant