Lowe et al. 2019 Fig S2 (+smoke tests); new optical formulae and products (optical depth & albedo); LWP product; activation-filtered r_eff product; cleanups #1256

claresinger · 2024-01-28T01:09:41Z

TODO

move optical calculations into Products and Formulae (see add products for cloud radiative effect #1251)
switch to filtered reff for tau calculation
switch the CDNC from ActivatedFraction * Na to using the new filtered product

Co-authored-by: Sanket Bhiogade <[email protected]> Co-authored-by: Sylwester Arabas <[email protected]>

…depth and albedo. need to add smoke test. move optical property calculations into Products.

…t can be accessed by all notebooks and all tests

claresinger · 2024-01-28T03:38:01Z

pylint error is confusing because the "unused imports" are actually used in the notebook...

************* Module PySDM_examples.Lowe_et_al_2019.fig_s2
examples/PySDM_examples/Lowe_et_al_2019/fig_s2.ipynb:cell_2:4:0: W0611: Unused show_plot imported from open_atmos_jupyter_utils (unused-import)
examples/PySDM_examples/Lowe_et_al_2019/fig_s2.ipynb:cell_2:8:0: W0611: Unused in_unit imported from PySDM.physics (unused-import)
examples/PySDM_examples/Lowe_et_al_2019/fig_s2.ipynb:cell_2:14:0: W0611: Unused pyplot imported from matplotlib (unused-import)

-----------------------------------
Your code has been rated at 9.99/10

slayoo · 2024-01-28T03:48:52Z

@claresinger for the massive number of precommit changes (caused by a new release of black just 2 days ago: https://pypi.org/project/black/24.1.0/), let's have a separate PR: #1257

slayoo · 2024-01-28T17:24:29Z

OK, we're back at "Files changed: 16" :)

…tent product. I realize this is a duplicate of water_mixing_ratio, but it was odd to me that the ice and liquid products are not named/calculated in the same way.

…a pointwise product, not an integral, wasn't sure how to do that... help needed. [skip ci]

claresinger · 2024-01-29T23:05:28Z

@slayoo I'm going to need some help with the logic for calculating the integral products... an attempt is in cloud_water_path.py :)

… backend; leaving one thread free with n_jobs=-2; workarounding match-case statement incompatibility for older Pythons

…e from an IDE); fixing test parameter name

…lasses

…ving one threa free (n_jobs=-2)

… and a kwarg causing failure in condensation tests.

claresinger · 2024-02-15T00:35:11Z

Closes #1251

bhiogade and others added 14 commits January 8, 2024 17:23

Add render-on-github badge and fix my binder link (open-atmos#1214)

befc1d0

Co-authored-by: Sanket Bhiogade <[email protected]> Co-authored-by: Sylwester Arabas <[email protected]>

Merge remote-tracking branch 'oa/main'

cedb1d0

Merge remote-tracking branch 'oa/main'

b66a05d

Merge remote-tracking branch 'oa/main'

d1c428e

Merge remote-tracking branch 'oa/main'

9423828

Merge remote-tracking branch 'oa/main'

fb9a0b2

Merge remote-tracking branch 'oa/main'

9f1333f

Merge remote-tracking branch 'oa/main'

c863ac9

Merge remote-tracking branch 'oa/main'

6db9c53

start example figure to replicate Fig S2 from Lowe including optical …

86788e8

…depth and albedo. need to add smoke test. move optical property calculations into Products.

update nu_w to water_molar_volume

b3b613c

move definition of constants for the example into a separate file tha…

0c71d01

…t can be accessed by all notebooks and all tests

linting

fa7dd64

precommit update

d40f11d

Merge branch 'main' into lowe_s2

ab8b133

claresinger added 4 commits January 29, 2024 17:57

use activated filter for effective radius and cdnc throughout example

bfa2034

change to CDNC product in test too

11f88f5

make liquid_water_content product to be consistent with ice_water_con…

a790646

…tent product. I realize this is a duplicate of water_mixing_ratio, but it was odd to me that the ice and liquid products are not named/calculated in the same way.

try adding CWP, LWP, IWP products. this doesn't work yet. it's still …

bcfc832

…a pointwise product, not an integral, wasn't sure how to do that... help needed. [skip ci]

claresinger and others added 7 commits January 30, 2024 12:12

wip adding formulae for optical depth and albedo [skip ci]

0054705

Merge remote-tracking branch 'oa/main' into lowe_s2

445dd10

Merge remote-tracking branch 'oa/main' into lowe_s2

b5767b4

removing CI=True; switching from process-based to thread-based joblib…

80acfee

… backend; leaving one thread free with n_jobs=-2; workarounding match-case statement incompatibility for older Pythons

adding a TestFigS2 class (to make it easier to run all tests in a fil…

686f3cc

…e from an IDE); fixing test parameter name

more code reuse across EffectiveRadius and ActivatedEffectiveRadius c…

d48f5e7

…lasses

switching from process-based loky to thread-based joblib backend; lea…

50b4821

…ving one threa free (n_jobs=-2)

claresinger force-pushed the lowe_s2 branch from aff7de6 to 5c7beab Compare February 13, 2024 15:17

slayoo and others added 21 commits February 13, 2024 17:29

introducing a contextmanager for disabling numba threading

f6e2c75

taking into account parcel volume profile in integration of LWP

37bf7cc

fix conditional logic

8deb04a

fix to the last fix

b3983da

add simple unit tests for optical formulae (only units check)

3b16827

add Null default classes for optical formulae

aa498c2

improving error message

338c3f0

adding unit test for effective radii

6145399

make using dummy attributes possible without adding Condensation dynamic

1ef4f22

turn on GPU testing for effective radius test

308481b

implementing pylint hints

829edca

removing spurious organic volfrac settings in tests

e10482a

try to fix failing tests. optical_depth is being used as the formulae…

18400a3

… and a kwarg causing failure in condensation tests.

trying to debug 'no attribute 'tau'' error [skip ci]

36fdd3c

fix lack of optical formulae issue

47075e9

uncommenting test code

68a31c8

adding test for liquid water path (still without an assert)

1c295fb

fixing integration logic in LWP product + assert in test

41d4fa8

pylint fixes. and error in s2 notebook plot.

9dc0d2a

give 1% error for monotonicity test on Lowe S2 [skip ci]

1ad310c

adjust overzealous tolerances

41b9488

slayoo approved these changes Feb 14, 2024

View reviewed changes

slayoo changed the title ~~Lowe example Fig S2 and smoke test~~ Lowe et al. 2019 Fig S2 (+smoke tests); new optical formulae and products (optical depth & albedo); LWP product; activation-filtered r_eff product; cleanups Feb 15, 2024

claresinger added this pull request to the merge queue Feb 15, 2024

Merged via the queue into open-atmos:main with commit cb50957 Feb 15, 2024
106 of 107 checks passed

slayoo mentioned this pull request Feb 15, 2024

add products for cloud radiative effect #1251

Open

claresinger deleted the lowe_s2 branch September 15, 2024 15:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lowe et al. 2019 Fig S2 (+smoke tests); new optical formulae and products (optical depth & albedo); LWP product; activation-filtered r_eff product; cleanups #1256

Lowe et al. 2019 Fig S2 (+smoke tests); new optical formulae and products (optical depth & albedo); LWP product; activation-filtered r_eff product; cleanups #1256

claresinger commented Jan 28, 2024 •

edited

Loading

claresinger commented Jan 28, 2024

slayoo commented Jan 28, 2024

slayoo commented Jan 28, 2024

claresinger commented Jan 29, 2024

claresinger commented Feb 15, 2024

Lowe et al. 2019 Fig S2 (+smoke tests); new optical formulae and products (optical depth & albedo); LWP product; activation-filtered r_eff product; cleanups #1256

Lowe et al. 2019 Fig S2 (+smoke tests); new optical formulae and products (optical depth & albedo); LWP product; activation-filtered r_eff product; cleanups #1256

Conversation

claresinger commented Jan 28, 2024 • edited Loading

claresinger commented Jan 28, 2024

slayoo commented Jan 28, 2024

slayoo commented Jan 28, 2024

claresinger commented Jan 29, 2024

claresinger commented Feb 15, 2024

claresinger commented Jan 28, 2024 •

edited

Loading