Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement piecewise-linear rhod profile in condensation methods #1106

Merged
merged 46 commits into from
Aug 21, 2023
Merged

Implement piecewise-linear rhod profile in condensation methods #1106

merged 46 commits into from
Aug 21, 2023

Commits on Aug 17, 2023

  1. Implement piecewise linear rhod profile in condensation methods

    @mikhailmints @slayoo
    mikhailmints authored and slayoo committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    bd26fa3 View commit details
    Browse the repository at this point in the history

  2. add MM to .zenodo.json credits file

    @slayoo
    slayoo committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c8099c0 View commit details
    Browse the repository at this point in the history

  3. Implement piecewise linear rhod profile in scipy condensation solver

    @mikhailmints @slayoo
    mikhailmints authored and slayoo committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    1a5249c View commit details
    Browse the repository at this point in the history

  4. Changing rtol in scipy solver eliminates error; remove xfail that now… 

    … passes; last, first name
    @mikhailmints @slayoo
    mikhailmints authored and slayoo committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    9a1c5f4 View commit details
    Browse the repository at this point in the history

  5. Formatting

    @mikhailmints @slayoo
    mikhailmints authored and slayoo committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    8031500 View commit details
    Browse the repository at this point in the history

  6. add a parcel not-so-unit test depicting noisy supersaturation issue c… 

    …aused by inconsistent density discretisation
    @slayoo
    slayoo committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    00e7de0 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. new rhod update logic for GPU backend

    @slayoo
    slayoo committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    ce7955b View commit details
    Browse the repository at this point in the history

  2. pre-commit changes

    @slayoo
    slayoo committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    c015cbf View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. mark test as XFAIL on GPU + issue label

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    3e62ed0 View commit details
    Browse the repository at this point in the history

  2. document in Particulator's condensation routine that dthd_dt_pred and… 

    … dqv_dt_pred are always 0 for Parcel env, while rhod is constant-in-time for kinematic simulations; mark volume as updated. Closes open-atmos#792
    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    1739c76 View commit details
    Browse the repository at this point in the history

  3. increase CI single-test timeout

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    0e7f2da View commit details
    Browse the repository at this point in the history

  4. pre-commit fixes

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    e123d39 View commit details
    Browse the repository at this point in the history

  5. mar_updated("volume") is now done within Particulator

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    820983a View commit details
    Browse the repository at this point in the history

  6. add sanity check to Concensation ctor not to set substeps count when … 

    …adaptivity is on
    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    5cd0df6 View commit details
    Browse the repository at this point in the history

  7. one less local var (rhod_mean)

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    a04ec2d View commit details
    Browse the repository at this point in the history

  8. fix arg modification logic in Thrust condensation

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    f82be9c View commit details
    Browse the repository at this point in the history

  9. add TODO label

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    6b6a6e1 View commit details
    Browse the repository at this point in the history

  10. pre-commit fixes

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    0b58c4f View commit details
    Browse the repository at this point in the history

  11. fix todo label

    @slayoo
    slayoo authored Aug 19, 2023
    Configuration menu
    Copy the full SHA
    75baa2a View commit details
    Browse the repository at this point in the history

  12. Implement piecewise linear rhod profile in condensation methods

    @mikhailmints @slayoo
    mikhailmints authored and slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    57a2a93 View commit details
    Browse the repository at this point in the history

  13. add MM to .zenodo.json credits file

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    38f9ffd View commit details
    Browse the repository at this point in the history

  14. Implement piecewise linear rhod profile in scipy condensation solver

    @mikhailmints @slayoo
    mikhailmints authored and slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    c9bc393 View commit details
    Browse the repository at this point in the history

  15. Changing rtol in scipy solver eliminates error; remove xfail that now… 

    … passes; last, first name
    @mikhailmints @slayoo
    mikhailmints authored and slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    eff7dd6 View commit details
    Browse the repository at this point in the history

  16. Formatting

    @mikhailmints @slayoo
    mikhailmints authored and slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    5606740 View commit details
    Browse the repository at this point in the history

  17. add a parcel not-so-unit test depicting noisy supersaturation issue c… 

    …aused by inconsistent density discretisation
    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    b78d084 View commit details
    Browse the repository at this point in the history

  18. new rhod update logic for GPU backend

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    b83abca View commit details
    Browse the repository at this point in the history

  19. pre-commit changes

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    1e96ca9 View commit details
    Browse the repository at this point in the history

  20. mark test as XFAIL on GPU + issue label

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    7b93304 View commit details
    Browse the repository at this point in the history

  21. document in Particulator's condensation routine that dthd_dt_pred and… 

    … dqv_dt_pred are always 0 for Parcel env, while rhod is constant-in-time for kinematic simulations; mark volume as updated. Closes open-atmos#792
    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    878a3f6 View commit details
    Browse the repository at this point in the history

  22. increase CI single-test timeout

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    01034b8 View commit details
    Browse the repository at this point in the history

  23. pre-commit fixes

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    e47b3b4 View commit details
    Browse the repository at this point in the history

  24. mar_updated("volume") is now done within Particulator

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    7c1ee33 View commit details
    Browse the repository at this point in the history

  25. add sanity check to Concensation ctor not to set substeps count when … 

    …adaptivity is on
    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    538b077 View commit details
    Browse the repository at this point in the history

  26. one less local var (rhod_mean)

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    2e857fc View commit details
    Browse the repository at this point in the history

  27. fix arg modification logic in Thrust condensation

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    093c2d6 View commit details
    Browse the repository at this point in the history

  28. add TODO label

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    26f9a30 View commit details
    Browse the repository at this point in the history

  29. pre-commit fixes

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    f396359 View commit details
    Browse the repository at this point in the history

  30. Merge branch 'piecewise_linear_profile' of github.com:mikhailmints/Py… 

    …SDM into pr_1106
    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    ed4669a View commit details
    Browse the repository at this point in the history

  31. Merge branch 'main' of github.com:open-atmos/PySDM into pr_1106

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    6f6a9cc View commit details
    Browse the repository at this point in the history

  32. fix substep spectification logic in 2d kinematic example

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    9df7fe5 View commit details
    Browse the repository at this point in the history

  33. pre-commit

    @slayoo
    slayoo committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    2d8e0ee View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. try shortening smoke test execution time

    @slayoo
    slayoo committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    080debc View commit details
    Browse the repository at this point in the history

  2. precommit

    @slayoo
    slayoo committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    ea0fccd View commit details
    Browse the repository at this point in the history

  3. try lower rtol

    @slayoo
    slayoo authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    a71f403 View commit details
    Browse the repository at this point in the history

  4. try even larger tolerance

    @slayoo
    slayoo authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    bf51ece View commit details
    Browse the repository at this point in the history

  5. revert rtol back to 1e-6

    @slayoo
    slayoo authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8b0491e View commit details
    Browse the repository at this point in the history