add missing fill() abstract method to StorageBase (#1119)

open-atmos · Aug 19, 2023 · 679b6b8 · 679b6b8
1 parent 31428dc
commit 679b6b8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/PySDM/backends/impl_common/storage_utils.py b/PySDM/backends/impl_common/storage_utils.py
@@ -56,6 +56,10 @@ def urand(self, generator):
     def upload(self, data):
         raise NotImplementedError()
 
+    @abstractmethod
+    def fill(self, other):
+        raise NotImplementedError()
+
 
 def get_data_from_ndarray(array, storage_class: Type[StorageBase], copy_fun):
     if str(array.dtype).startswith("int"):

diff --git a/PySDM/backends/impl_thrust_rtc/storage.py b/PySDM/backends/impl_thrust_rtc/storage.py
@@ -497,14 +497,14 @@ def divide_if_not_zero(self, divisor):
             Impl.divide_if_not_zero(self, divisor)
             return self
 
-        def fill(self, value):
-            if isinstance(value, Storage):
-                trtc.Copy(value.data, self.data)
+        def fill(self, other):
+            if isinstance(other, Storage):
+                trtc.Copy(other.data, self.data)
             else:
-                if isinstance(value, int):
-                    dvalue = trtc.DVInt64(value)
-                elif isinstance(value, float):
-                    dvalue = BACKEND._get_floating_point(value)
+                if isinstance(other, int):
+                    dvalue = trtc.DVInt64(other)
+                elif isinstance(other, float):
+                    dvalue = BACKEND._get_floating_point(other)
                 else:
                     raise TypeError("Only Storage, int and float are supported.")
                 trtc.Fill(self.data, dvalue)