Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a basic test case draft checking parsing of chamber loss_function params #369

Merged
merged 3 commits into from
Aug 8, 2024
Merged

add a basic test case draft checking parsing of chamber loss_function params #369

merged 3 commits into from
Aug 8, 2024

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Jul 30, 2024 •
edited by jcurtis2
Loading

Resolves #367

@slayoo slayoo requested a review from jcurtis2 July 30, 2024 16:29
@slayoo slayoo mentioned this pull request Jul 30, 2024
Closed
@slayoo
Copy link
Member Author

slayoo commented Aug 8, 2024

thanks @jcurtis2 for the 'constant' case!
Should we merge?

@slayoo slayoo added this pull request to the merge queue Aug 8, 2024
Merged via the queue into open-atmos:main with commit d00cbd8 Aug 8, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcurtis2 jcurtis2 jcurtis2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

try out setting Scenario loss_function to something else than "none" (based on PartMC examples)
2 participants
@slayoo @jcurtis2