This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Fix: Loud promise rejection without init #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 27, 2017 09:47
This should fix issues with loud promise rejections when Opbeat isn't initialized, for example when running tests.
|
I'm worried that the user will import something between edit: For example, if a library comes with it's own Promise polyfill, discovers there are no native Promises, defines their own and then use their embedded version, zone.js will not be effective on those. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Load opbeat-zone only when intialized
This should fix issues with loud promise rejections when
Opbeat isn't initialized, for example when running tests.
See: https://app.intercom.io/a/apps/645h60ha/inbox/all/conversations/9013266038?nsrc=slack