This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
temp: Main diff #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small changes to the deposit tx primitive
Move feature flags below comments
clabby
force-pushed
the
clabby/goerli-genesis
branch
4 times, most recently
from
1f32098 to
9f40b06
Compare
Remove `consensus` crate `Cargo.toml` Reduce diff
clabby
force-pushed
the
clabby/goerli-genesis
branch
from
9f40b06 to
a794926
Compare
clabby
force-pushed
the
clabby/goerli-genesis
branch
from
0b15761 to
2e4bdb9
Compare
clabby
force-pushed
the
clabby/goerli-genesis
branch
from
722bc2f to
ca2a249
Compare
clabby
added a commit
that referenced
this pull request
Aug 12, 2023
clabby
added a commit
that referenced
this pull request
Aug 13, 2023
Co-authored-by: Brian Bland <[email protected]> Co-authored-by: refcell <[email protected]> Co-authored-by: nicolas <[email protected]> Co-authored-by: Roberto <[email protected]> Resolution checkpoint Resolution checkpoint #2 Resolution checkpoint #3 x Resolution checkpoint #4 Resolution checkpoint #5 Resolution checkpoint #6 Resolution checkpoint #7 Resolution checkpoint #8 Resolve checkpoint #9 (transaction primitive) Resolve checkpoint #10 (rpc api transactions) Resolve checkpoint #11 (building w/o feature flag) Start review Compiling with and without `optimism` feature flag Remove `DepositTx` from txpool mock tests, they never go into the txpool fmt code lint fix signature tests Co-authored-by: nicolas <[email protected]> Use free CI runners (revert before upstream) Co-authored-by: refcell <[email protected]> Signature test fixes Co-authored-by refcell <[email protected]> Fix Receipt proptest Co-authored-by BB <[email protected]> lint Fix variable-length compact for txtype/transaction Co-authored-by: Brian Bland <[email protected]> Fix basefee tests Remove unnecessary rpc deps
clabby
added a commit
that referenced
this pull request
Aug 13, 2023
Resolution checkpoint Resolution checkpoint #2 Resolution checkpoint #3 x Resolution checkpoint #4 Resolution checkpoint #5 Resolution checkpoint #6 Resolution checkpoint #7 Resolution checkpoint #8 Resolve checkpoint #9 (transaction primitive) Resolve checkpoint #10 (rpc api transactions) Resolve checkpoint #11 (building w/o feature flag) Start review Compiling with and without `optimism` feature flag Remove `DepositTx` from txpool mock tests, they never go into the txpool fmt code lint fix signature tests Co-authored-by: nicolas <[email protected]> Use free CI runners (revert before upstream) Co-authored-by: refcell <[email protected]> Signature test fixes Co-authored-by refcell <[email protected]> Fix Receipt proptest Co-authored-by BB <[email protected]> lint Fix variable-length compact for txtype/transaction Co-authored-by: Brian Bland <[email protected]> Fix basefee tests Remove unnecessary rpc deps Co-authored-by: Brian Bland <[email protected]> Co-authored-by: refcell <[email protected]> Co-authored-by: nicolas <[email protected]> Co-authored-by: Roberto <[email protected]>
clabby
added a commit
that referenced
this pull request
Aug 13, 2023
Resolution checkpoint Resolution checkpoint #2 Resolution checkpoint #3 x Resolution checkpoint #4 Resolution checkpoint #5 Resolution checkpoint #6 Resolution checkpoint #7 Resolution checkpoint #8 Resolve checkpoint #9 (transaction primitive) Resolve checkpoint #10 (rpc api transactions) Resolve checkpoint #11 (building w/o feature flag) Start review Compiling with and without `optimism` feature flag Remove `DepositTx` from txpool mock tests, they never go into the txpool fmt code lint fix signature tests Co-authored-by: nicolas <[email protected]> Use free CI runners (revert before upstream) Co-authored-by: refcell <[email protected]> Signature test fixes Co-authored-by refcell <[email protected]> Fix Receipt proptest Co-authored-by BB <[email protected]> lint Fix variable-length compact for txtype/transaction Co-authored-by: Brian Bland <[email protected]> Fix basefee tests Remove unnecessary rpc deps Co-authored-by: Brian Bland <[email protected]> Co-authored-by: refcell <[email protected]> Co-authored-by: nicolas <[email protected]> Co-authored-by: Roberto <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temp PR to show the diff between
mainandclabby/goerli-genesis