Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webconnectivitylte: implement summary generation #2667

Closed
bassosimone opened this issue Feb 6, 2024 · 0 comments · Fixed by ooni/probe-cli#1493
Closed

webconnectivitylte: implement summary generation #2667

bassosimone opened this issue Feb 6, 2024 · 0 comments · Fixed by ooni/probe-cli#1493
Assignees
@bassosimone
Labels
funder/otffoss2023-2024

Comments

@bassosimone
Copy link
Contributor

We want to generate a summary for Web Connectivity LTE. While there, the code for generating summaries is brittle and legacy, so we should do some KTLO work to make sure we leave the camp slightly cleaner.
@bassosimone bassosimone self-assigned this Feb 6, 2024
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 6, 2024
@bassosimone
Start improving how we set summary keys
d0bf708 
Lots of errors and bugfixes still needed but let's publish
the branch first and then continue hammering it.

See ooni/probe#2667
@bassosimone bassosimone mentioned this issue Feb 6, 2024
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 7, 2024
@bassosimone
cleanup(all): remove the run experiment
011341f 
We used the run experiment for the DoT and DoH blocking paper,
i.e., https://censorbib.nymity.ch/#Basso2021a.

Beyond that, the run experiment has never been advertised and its
functionality duplicates some OONI Run v2 functionality.

Therefore, it's safe to remove this experiment, which will make
ooni/probe#2667 easier to implement.
@bassosimone bassosimone mentioned this issue Feb 7, 2024
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 7, 2024
@bassosimone
cleanup(all): remove the run experiment (#1492)
07a26f4 
We used the run experiment for the DoT and DoH blocking paper, i.e.,
https://censorbib.nymity.ch/#Basso2021a.

Beyond that, the run experiment has never been advertised and its
functionality duplicates some OONI Run v2 functionality.

Therefore, it's safe to remove this experiment, which will make
ooni/probe#2667 easier to implement.
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 7, 2024
@bassosimone
refactor(all): improve SummaryKeys management (#1491)
0f5529f 
While approaching ooni/probe#2667, I
recognized that the approach we're using to generate `SummaryKeys` is
redundant, verbose, and fragile. This diff attempts to improve our
implementation.

We define new types for generating summary keys and
`engine.MeasurementSummaryKeys` to either return the proper summary
keys, if the experiment `TestKeys` support that or return a default
value.

While there, disable the flaky `throttlingWithHTTP` QA check (see
ooni/probe#2668).
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 7, 2024
@bassosimone
feat(webconnectivitylte): wire-in SummaryKeys
521e6ca 
Closes ooni/probe#2667
@bassosimone bassosimone mentioned this issue Feb 7, 2024
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Feb 7, 2024
@bassosimone
feat(webconnectivitylte): wire-in SummaryKeys (#1493)
b89a15f 
Closes ooni/probe#2667.

While there, repair flaky unit test and explain why it was flaky.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
cleanup(all): remove the run experiment (ooni#1492)
eeab472 
We used the run experiment for the DoT and DoH blocking paper, i.e.,
https://censorbib.nymity.ch/#Basso2021a.

Beyond that, the run experiment has never been advertised and its
functionality duplicates some OONI Run v2 functionality.

Therefore, it's safe to remove this experiment, which will make
ooni/probe#2667 easier to implement.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
refactor(all): improve SummaryKeys management (ooni#1491)
21db18c 
While approaching ooni/probe#2667, I
recognized that the approach we're using to generate `SummaryKeys` is
redundant, verbose, and fragile. This diff attempts to improve our
implementation.

We define new types for generating summary keys and
`engine.MeasurementSummaryKeys` to either return the proper summary
keys, if the experiment `TestKeys` support that or return a default
value.

While there, disable the flaky `throttlingWithHTTP` QA check (see
ooni/probe#2668).
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
feat(webconnectivitylte): wire-in SummaryKeys (ooni#1493)
b964cd6 
Closes ooni/probe#2667.

While there, repair flaky unit test and explain why it was flaky.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
funder/otffoss2023-2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(webconnectivitylte): wire-in SummaryKeys ooni/probe-cli
1 participant
@bassosimone