Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtor: make building on Linux more robust #2651

Closed
3 tasks done
bassosimone opened this issue Jan 15, 2024 · 3 comments · Fixed by ooni/probe-cli#1501
Closed
3 tasks done

libtor: make building on Linux more robust #2651

bassosimone opened this issue Jan 15, 2024 · 3 comments · Fixed by ooni/probe-cli#1501
Assignees
Labels
bug Something isn't working ooni/probe-engine platform/linux priority/low user feedback requests that have been added to the backlog as a direct result of user feedback or testing

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Jan 15, 2024

  • pass --disable-system-torrc to ./configure to avoid picking up a system torrc in integration tests (which is also more correct to do on mobile devices anyway);
  • pass --disable-seccomp to ./configure to avoid picking up libseccomp, which we don't have on mobile anyway;
  • patch the build system to avoid trying to use libcap2, given that we don't have that on mobile anyway.

Based on a conversation with @ainghazal during the review of ooni/probe-cli#1445.

@bassosimone bassosimone added bug Something isn't working priority/medium user feedback requests that have been added to the backlog as a direct result of user feedback or testing platform/linux ooni/probe-engine labels Jan 15, 2024
@bassosimone bassosimone self-assigned this Jan 15, 2024
@bassosimone
Copy link
Contributor Author

% cat LOGS.txt|grep cap_init
checking for cap_init in -lcap... no
checking for cap_init in -lcap... no
checking for cap_init in -lcap... no
checking for cap_init in -lcap... no

% cat LOGS.txt|grep seccomp
checking seccomp.h usability... no
checking seccomp.h presence... no
checking for seccomp.h... no
checking for library containing seccomp_init... no
  libseccomp (--disable-seccomp):                                yes
checking seccomp.h usability... no
checking seccomp.h presence... no
checking for seccomp.h... no
checking for library containing seccomp_init... no
  libseccomp (--disable-seccomp):                                yes
checking seccomp.h usability... no
checking seccomp.h presence... no
checking for seccomp.h... no
checking for library containing seccomp_init... no
  libseccomp (--disable-seccomp):                                yes
checking seccomp.h usability... no
checking seccomp.h presence... no
checking for seccomp.h... no
checking for library containing seccomp_init... no
  libseccomp (--disable-seccomp):                                yes

This is the Android build.

@bassosimone
Copy link
Contributor Author

% cat LOGS.txt|grep cap_init
checking for cap_init in -lcap... no
checking for cap_init in -lcap... no
checking for cap_init in -lcap... no

% cat LOG.txt|grep seccomp
checking seccomp.h usability... no
checking seccomp.h presence... no
checking for seccomp.h... no
checking for library containing seccomp_init... no
  libseccomp (--disable-seccomp):                                yes
checking seccomp.h usability... no
checking seccomp.h presence... no
checking for seccomp.h... no
checking for library containing seccomp_init... no
  libseccomp (--disable-seccomp):                                yes
checking seccomp.h usability... no
checking seccomp.h presence... no
checking for seccomp.h... no
checking for library containing seccomp_init... no
  libseccomp (--disable-seccomp):                                yes

and this is iOS.

@ainghazal
Copy link

fwiw, I can confirm the tests mentioned in ooni/probe-cli#1445 can run successfully on an arch system now.

Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ooni/probe-engine platform/linux priority/low user feedback requests that have been added to the backlog as a direct result of user feedback or testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants