Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add echcheck to the experimental suite #2547

Closed
bassosimone opened this issue Oct 4, 2023 · 1 comment
Closed

cli: add echcheck to the experimental suite #2547

bassosimone opened this issue Oct 4, 2023 · 1 comment
Assignees
@bassosimone
Labels
releaseBlocker This issue blocks releasing

Comments

@bassosimone
Copy link
Contributor

This issue captures the work done by @kelmenhorst in ooni/probe-cli#1217.
@bassosimone bassosimone added the releaseBlocker This issue blocks releasing label Oct 4, 2023
@bassosimone bassosimone self-assigned this Oct 4, 2023
@bassosimone bassosimone mentioned this issue Oct 4, 2023
Merged
4 tasks
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 11, 2023
@kelmenhorst @bassosimone
feat: add echcheck to the experimental suite (#1217)
39019d0 
## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
ooni/probe#1453
ooni/probe#2547
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request:
https://github.com/kelmenhorst/spec/tree/echcheck-spec
- [x] if you changed code inside an experiment, make sure you bump its
version number

## Description

This diff does two things:

1. Add `echcheck` to the experimental nettest suite. We do not provide
input which causes the experiment to use the default URL
`https://crypto.cloudflare.com/cdn-cgi/trace` (URL
[proposed](ooni/probe#1453 (comment))
by @eighthave). With this single input configuration we can collect the
first experimental ECH measurements.

2. Add netem tests to `echcheck`, while keeping a "real-internet" test
to connect to an ECH-enabled server.

---------

Co-authored-by: Simone Basso <[email protected]>
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 11, 2023
@bassosimone
fix(ooniprobe): make sure we actually run echcheck
a2f0982 
While there, emit some logs while running it.

While there, make the warning emitted when a nettest is disabled
much more specific and informative for the user.

Part of ooni/probe#2547

Part of ooni/probe#2553
@bassosimone bassosimone mentioned this issue Oct 11, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 11, 2023
@bassosimone
fix(ooniprobe): make sure we actually run echcheck (#1358)
e6e00dc 
While there, emit some logs while running it.

While there, make the warning emitted when a nettest is disabled much
more specific and informative for the user.

Part of ooni/probe#2547

Part of ooni/probe#2553
@bassosimone
Copy link
Contributor Author

Done!

bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 11, 2023
@kelmenhorst @bassosimone
[backport] feat: add echcheck to the experimental suite
a8f4fc2 
This diff backports #1217 to the release/3.19 branch.

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
ooni/probe#1453
ooni/probe#2547
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request:
https://github.com/kelmenhorst/spec/tree/echcheck-spec
- [x] if you changed code inside an experiment, make sure you bump its
version number

This diff does two things:

1. Add `echcheck` to the experimental nettest suite. We do not provide
input which causes the experiment to use the default URL
`https://crypto.cloudflare.com/cdn-cgi/trace` (URL
[proposed](ooni/probe#1453 (comment))
by @eighthave). With this single input configuration we can collect the
first experimental ECH measurements.

2. Add netem tests to `echcheck`, while keeping a "real-internet" test
to connect to an ECH-enabled server.

---------

Co-authored-by: Simone Basso <[email protected]>
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 11, 2023
@bassosimone
[backport] fix(ooniprobe): make sure we actually run echcheck
d13a7ca 
This diff backports #1358 to the release/3.19 branch.

While there, emit some logs while running it.

While there, make the warning emitted when a nettest is disabled much
more specific and informative for the user.

Part of ooni/probe#2547

Part of ooni/probe#2553
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@kelmenhorst @bassosimone @Murphy-OrangeMud
feat: add echcheck to the experimental suite (ooni#1217)
f5af9a7 
## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
ooni/probe#1453
ooni/probe#2547
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request:
https://github.com/kelmenhorst/spec/tree/echcheck-spec
- [x] if you changed code inside an experiment, make sure you bump its
version number

## Description

This diff does two things:

1. Add `echcheck` to the experimental nettest suite. We do not provide
input which causes the experiment to use the default URL
`https://crypto.cloudflare.com/cdn-cgi/trace` (URL
[proposed](ooni/probe#1453 (comment))
by @eighthave). With this single input configuration we can collect the
first experimental ECH measurements.

2. Add netem tests to `echcheck`, while keeping a "real-internet" test
to connect to an ECH-enabled server.

---------

Co-authored-by: Simone Basso <[email protected]>
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
fix(ooniprobe): make sure we actually run echcheck (ooni#1358)
ba7e913 
While there, emit some logs while running it.

While there, make the warning emitted when a nettest is disabled much
more specific and informative for the user.

Part of ooni/probe#2547

Part of ooni/probe#2553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
releaseBlocker This issue blocks releasing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bassosimone