Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/cd: workarounds for bsdtar being broken in macos-11 #1884

Closed
bassosimone opened this issue Nov 19, 2021 · 1 comment
Closed

ci/cd: workarounds for bsdtar being broken in macos-11 #1884

bassosimone opened this issue Nov 19, 2021 · 1 comment
Assignees
@bassosimone
Labels
priority/medium

Comments

@bassosimone
Copy link
Contributor

We've noticed that bsdtar completely botches binaries when using macos-11. We are not alone:

These two github issues describe also possible workarounds. (We need macos-11 to build for darwin/arm64.)
@bassosimone bassosimone self-assigned this Nov 19, 2021
@bassosimone
Copy link
Contributor Author

This is not necessary. I've resorted to a very stupid trick: not using tar for publishing files.

bassosimone added a commit to ooni/probe-desktop that referenced this issue Nov 24, 2021
@bassosimone
chore: use ooniprobe-cli 3.11.0-beta.2
5302fdf 
This diff changes ooniprobe-desktop to use cli v3.11.0-beta.2.

This cli release includes changes in the last (at this point six!)
months to improve measurements quality.

It is missing some extra fixes required to bless a stable
release. Chiefly among them, the possiblity of running
cleanly the DNSCheck experiment.

I'm going to work on these issues as soon as possible.

In the meanwhile, this release is a good testing base to check
whether we have additional lingering issues.

A few notes to explain this diff follows.

First, I took the liberty of reducing as much as possible
the amount of markdown linting warning I did see.

Second, 3.11.0-beta.2 is the first release that is fully built
using the cloud. I have not added any PGP key to the cloud
as this seems a bit futile. Maybe it is not and maybe I'm not
seeing the full picture, so we should discuss this topic. (I
would not put my PGP key in there, and instead I'd put another
key that has no password to sign releases; is this better
than not using any key at all?)

Third, cloud builds do not use tar.gz anymore. I did this to
work around ooni/probe#1884 (in general,
less pieces we use, less errors could occur.)

As a result, the download script needed a bit of reworking.

Fourth, while I reckon this is unlikely, I couldn't help noticing
that the previous script did not download in case files were
already on disk. To add a bit of robustness to this process, I
am now prefixing the downloaded file with its version. This way,
we'll re-download if there is a cli version change and there
are already files on disk and, by some other mistake, the build
rules are such that we don't clean existing files.

The related issue is ooni/probe#1879
@bassosimone bassosimone mentioned this issue Nov 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
priority/medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bassosimone