feat(make): build ooniprobe for darwin, windows, and linux #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ooni/probe#1466, a user is asking about arm64 builds for Debian. We already had some code for that in #311. Let us adapt the code to the `./make` script to have arm64 builds.
In ooni/probe#1466, a user is asking about arm64 builds for Debian. We already had some code for that in #311. Let us adapt the code to the `./make` script to have arm64 builds.
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
In ooni/probe#1466, a user is asking about arm64 builds for Debian. We already had some code for that in ooni#311. Let us adapt the code to the `./make` script to have arm64 builds. While there, also adapt the code for darwin and windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ooni/probe#1466, a user is asking
about arm64 builds for Debian. We already had some code for that
in #311. Let us adapt the
code to the
./makescript to have arm64 builds.While there, also adapt the code for darwin and windows.