chore: use ooni/probe-cli 3.11.0-beta.2 #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app was crashing because the code did not specify the pending intent as IMMUTABLE (as far as I understand the stacktrace). Closes ooni/probe#1897 (This is not my domain of expertise and I think this patch could and should be better refactored so that we always use a single factory to create all the intents with the correct flags.)
This diff addresses my previous concern that I fixed the immediate problem but did not proactively check the rest of the codebase. Now, `git grep -i pendingintent.newactivity` and `git grep -i pendingintent.getbroadcast` say that we have correctly wrapped all instance flags. See ooni/probe#1897
|
@lorenzoPrimi please, take a look! |
|
Tested and working as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ooni/probe#1879