Filter whitespaces in downloader fields in model tab #6518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added strip to repo_id and specific_file (for GGUF models). Fixes downloading when model/file copied with whitespace symbols.
cyberfox
pushed a commit
to cyberfox/text-generation-webui
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes users accidentally contaminate downloader fields in Model tab with whitespaces or newlines and it prevents from downloading models. As of now such contamination creates broken download links and it returns errors from HF and it can be confusing for a user since it's hard to notice such symbols in the text fields.
This PR adds strip() to "repo_id" and "specific_file" variables in the downloader to filter out such symbols.
Checklist: