Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple min_p preset, make it the default #5836

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Add a simple min_p preset, make it the default #5836

merged 1 commit into from
Apr 9, 2024

Conversation

oobabooga
Copy link
Owner

In my testing, it seems to work better than simple-1 for those recent models that finally rival ChatGPT (like Command R).

@oobabooga oobabooga merged commit cbd65ba into dev Apr 9, 2024
@oobabooga oobabooga deleted the min_p branch April 9, 2024 19:04
@randoentity
Copy link
Contributor

Thank you! This got rid of the command r+ repetition problems by setting the repetition penalty to 1. Furthermore, using min_p instead of top_p makes it nondeterministic.

PoetOnTheRun pushed a commit to PoetOnTheRun/text-generation-webui that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants