Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngrok logging does not use the shared logger module #5570

Merged
merged 1 commit into from
Feb 25, 2024
Merged

ngrok logging does not use the shared logger module #5570

merged 1 commit into from
Feb 25, 2024

Conversation

dsroark
Copy link
Contributor

@dsroark dsroark commented Feb 23, 2024

  • when running start_linux.sh, ngrok will not display the created URL unless the logs are run through the shared logger module

Checklist:

@dsroark dsroark changed the base branch from main to dev February 23, 2024 20:47
@oobabooga
Copy link
Owner

Thanks for the fix

@oobabooga oobabooga merged commit e0fc808 into oobabooga:dev Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsroark @oobabooga