-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom sampler order support #5443
Conversation
First of all, thanks a lot for deciding to go for that feature #5403 (comment), much appreciated. I did some tests with it and here's my suggestions:
|
This PR doesn't touch non-HF loaders. About UI, I agree that it could be improved, but gradio doesn't have an easy component for drag and drop a stack of values. That can be added later. You don't have to provide all parameters every time. If you are only using min_p, top_p, and temperature, you can write
|
Thank you for adding this🙏 |
IMO having a text box list of samplers works fine. This is great change, thanks for it. |
What this PR implements:
Deprecate(I'll keep it for now) For now, it moves temperature, dynamic_temperature, and quadratic_sampling to the end of the list, in an arbitrary order.temperature_last
, since it's no longer necessary.What this PR does not implement: