Openai embedding fix to support jina-embeddings-v2 #4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
|
tested embedding model: |
oobabooga
reviewed
Nov 18, 2023
extensions/openai/completions.py
Outdated
| @@ -235,7 +235,7 @@ def chat_completions_common(body: dict, is_legacy: bool = False, stream=False) - | |||
|
|
|||
| max_tokens = generate_params['max_new_tokens'] | |||
| if max_tokens in [None, 0]: | |||
| generate_params['max_new_tokens'] = 4096 | |||
| generate_params['max_new_tokens'] = 200 | |||
There was a problem hiding this comment.
Setting this high isn't necessary, as the auto_max_new_tokens fills the context. The 200 reference value is used when the context is fully used to remove old messages.
|
Looks good, thanks |
|
@wizd Does Jina embedding runs on cuda devices? Other setense transformer embedding always lies on CPU even if specifiying cuda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
tested with: https://huggingface.co/jinaai/jina-embeddings-v2-base-en