[Fix] fix openai embedding_model loading as str #4147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Related issue #4146
Logs and reprodution in the issue
This pr fix this line of code that leads to embeeding_model being assigned to str instead of intended an instance of SentenceTransformer #4146 (comment)
After the fix, the openai embedding begins working, here is the log after the fix with debug=1 in the openai extension.
When debug=1 [here], it now prints out embedding models and embedding results