Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Character's Memory section #119

Closed
Xabab opened this issue Feb 24, 2023 · 4 comments
Closed

Add the Character's Memory section #119

Xabab opened this issue Feb 24, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Xabab
Copy link

Xabab commented Feb 24, 2023

Putting statements after character's definition and after <START> statement but before the chat history is a great way to set up a custom memory, for example, putting this fragment:

  • You: Hello, my name is Name, I am 25, male and 1.7 meters tall
  • Giant: *you seem small, I tower above you with my 12 meters of height*

I noticed it helps immensely against some things such as ignoring difference in height, butchering user's name, confusing user's pronouns or any other info that characters are usually struggling with.
It could be left as it is, but on each load of a character, a <START> statement is added at the end at the moment.

@oobabooga
Copy link
Owner

I have changed how the example dialogue is handled. Now it is added to the context string (which is never truncated) instead of the chat history. This way, the Character's Memory that you describe can now simply be added at the top of the example dialogue when creating or editing a character.

@Xabab
Copy link
Author

Xabab commented Feb 28, 2023

Wouldn't call it a good solution, as it has to be unique to chat history, not per character. Plus the changes to the context text box aren't saved, so it is just as burdensome of a process, as you need to save your 'memory' elsewhere or edit json by hand quite often

upd: tho my feedback applies more to the # 124. this solution addresses this issue exhaustively, thank you

@Xabab
Copy link
Author

Xabab commented Feb 28, 2023

Hm. This actually produces another problem, as the example dialog eats up short-term memory, leaving less space for recent dialog.

Maybe would be better to check the description for containing <START> or Scenario: or both sub-strings?

@oobabooga
Copy link
Owner

Just make the character definition shorter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants