fix: pass cmp.Options to cmp.Diff in BeComparableToMatcher #563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to this PR introduced @xiantank.
As additional
cmp.Options
might be passed tocmp.Equal
method, the same should be passed tocmp.Diff
.In worst cases, lacking of options might cause a panic; eg. while using
If the exported values were different,
cmp.Equal
returnsfalse
andFailureMessage
will panic becausecmp.Diff
can't handle unexported fields.