Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for gomega version bump #1393

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix test for gomega version bump #1393

merged 1 commit into from
Apr 22, 2024

Conversation

Ygnas
Copy link
Contributor

@Ygnas Ygnas commented Apr 22, 2024

Gomega error message is different now: fail(fmt.Sprintf("Context was cancelled (cause: %s)", err))
This should unblock #1390

If it would be easier I can bump the version of gomega here as well.

Verification

  • Upgrade gomega to v1.33.0
  • All test should pass

@Ygnas
Copy link
Contributor Author

Ygnas commented Apr 22, 2024

I'll check it in a sec.

@Ygnas
Copy link
Contributor Author

Ygnas commented Apr 22, 2024

Test did not like () in regex should be good now

@onsi onsi merged commit f2fcd97 into onsi:master Apr 22, 2024
6 checks passed
@onsi
Copy link
Owner

onsi commented Apr 22, 2024

thanks y’all i’ve pulled this in now

@Ygnas
Copy link
Contributor Author

Ygnas commented Apr 22, 2024

After merge #1381, #1382, #1383 should pass as well, so test could be run there @onsi

@blgm
Copy link
Collaborator

blgm commented Apr 22, 2024

#1381, #1382, and #1383 are all done. Thanks for fixing the test @Ygnas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants