-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow MustPassRepeatedly decorator to be set at suite level #1266
Merged
onsi
merged 4 commits into
onsi:master
from
maxcleme:feat/allow_suite_level_must_pass_repeatedly
Aug 23, 2023
Merged
feat: allow MustPassRepeatedly decorator to be set at suite level #1266
onsi
merged 4 commits into
onsi:master
from
maxcleme:feat/allow_suite_level_must_pass_repeatedly
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: maxcleme <[email protected]>
Regarding the test, I'm not sure which way I should go
@onsi any thoughts? 😁 |
i’ll try to take a closer look today but to unblock you:
|
maxcleme
force-pushed
the
feat/allow_suite_level_must_pass_repeatedly
branch
from
August 23, 2023 14:36
81b93f0
to
81926db
Compare
Signed-off-by: maxcleme <[email protected]>
maxcleme
force-pushed
the
feat/allow_suite_level_must_pass_repeatedly
branch
from
August 23, 2023 14:38
81926db
to
5dbcd2a
Compare
maxcleme
commented
Aug 23, 2023
Signed-off-by: maxcleme <[email protected]>
…rride Signed-off-by: maxcleme <[email protected]>
maxcleme
force-pushed
the
feat/allow_suite_level_must_pass_repeatedly
branch
from
August 23, 2023 14:51
5dbcd2a
to
880399d
Compare
@onsi I've added some tests, let me know what you think! |
maxcleme
commented
Aug 23, 2023
i just cut a release with this in it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1265
Aims to allow
MustPassRepeatedly
to be set at suite level programatically, similarly ofFlakeAttempts
.