Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate internal should use add "_internal" to the test name #750

Closed
kevinkirkup opened this issue Dec 11, 2020 · 2 comments · Fixed by #751
Closed

Generate internal should use add "_internal" to the test name #750

kevinkirkup opened this issue Dec 11, 2020 · 2 comments · Fixed by #751

Comments

@kevinkirkup
Copy link
Contributor

When running the ginkgo generate -internal it creates a test file with the same name as without the -internal flag.
Most of the time I want to generate white box and blackbox tests.

It would be handy if adding the -internal flag would add _internal to the generated file name:

$ something_internal_tests.go

From looking around, it looks like this is a convention for internal tests.

@onsi
Copy link
Owner

onsi commented Dec 11, 2020

SGTM - are you up for submitting a PR for this?

@kevinkirkup
Copy link
Contributor Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants