Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using dot import for the package under test in ginkgo generate #683

Closed
alex-slynko opened this issue Jun 3, 2020 · 2 comments · Fixed by #687
Closed

Stop using dot import for the package under test in ginkgo generate #683

alex-slynko opened this issue Jun 3, 2020 · 2 comments · Fixed by #687

Comments

@alex-slynko
Copy link
Contributor

Hi there

I am happy user of Ginkgo for almost five years.
I am always puzzled by the default behaviour of ginkgo generate command. It generates output that includes dot import of the package under test. (Ie. import . my_package)

I went through repositories of some main Ginkgo contributors and saw that they don't do the dot import. It is similar to my experience - dot imports make code reading harder.

I propose to replace dot import with normal import in the test.

@onsi
Copy link
Owner

onsi commented Jun 3, 2020

hey @alex-slynko that a sounds good to me. Want to submit a PR? you might want to tweak the gh-pages branch too.

@alex-slynko
Copy link
Contributor Author

Sure, I'll send the PR later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants