Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added API to allow remote bulk loading of model and metrics data sets… #65

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

tomikazi
Copy link
Contributor

… into the simulator

}

message DataSet {
string type = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is type? Can we use enum here if we know the types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we could. I was trying to leave it open-ended. For now "model" and "rc.pci" are supported. If we use enum, we'll have to change API each time rather than just simulator. API and CLI could remain untouched if it is left as is, which is what I would prefer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. I was wondering what it refers to.

Copy link
Contributor

@adibrastegarnia adibrastegarnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also try it locally using go mod replace perhaps you will end up with more fields or changing the api but up to you @tomikazi

@tomikazi
Copy link
Contributor Author

You can also try it locally using go mod replace perhaps you will end up with more fields or changing the api but up to you @tomikazi

I'm already trying it with replace in go mod. :)

@tomikazi tomikazi merged commit c739e04 into onosproject:master Mar 17, 2021
@tomikazi tomikazi deleted the simapi branch March 17, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants