Add in Canceled Order check

onomyprotocol · May 26, 2024 · ffa5d54 · ffa5d54
1 parent 1cf06bc
commit ffa5d54
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/x/market/keeper/msg_server_cancel_order.go b/x/market/keeper/msg_server_cancel_order.go
@@ -19,6 +19,10 @@ func (k msgServer) CancelOrder(goCtx context.Context, msg *types.MsgCancelOrder)
 		return nil, sdkerrors.Wrapf(types.ErrOrderNotFound, "%s", msg.Uid)
 	}
 
+	if order.Status == "canceled" {
+		return nil, sdkerrors.Wrapf(types.ErrOrderCanceled, "%s", msg.Uid)
+	}
+
 	if order.Owner != msg.Creator {
 		return nil, sdkerrors.Wrapf(types.ErrNotOrderOwner, "%s", msg.Uid)
 	}

diff --git a/x/market/keeper/msg_server_cancel_order_test.go b/x/market/keeper/msg_server_cancel_order_test.go
@@ -69,6 +69,8 @@ func TestCancelOrder_case1_stop(t *testing.T) {
 	var co = types.MsgCancelOrder{Creator: addr, Uid: Uid}
 	_, err = keeper.NewMsgServerImpl(*testInput.MarketKeeper).CancelOrder(sdk.WrapSDKContext(testInput.Context), &co)
 	require.NoError(t, err)
+	_, err = keeper.NewMsgServerImpl(*testInput.MarketKeeper).CancelOrder(sdk.WrapSDKContext(testInput.Context), &co)
+	require.Error(t, err)
 
 	// Validate GetMember
 	memberA, memberfound = testInput.MarketKeeper.GetMember(testInput.Context, orders.DenomBid, orders.DenomAsk)

diff --git a/x/market/types/errors.go b/x/market/types/errors.go
@@ -54,4 +54,6 @@ var (
 	ErrDenomExists = sdkerrors.Register(ModuleName, 22, "denom already exists") // nolint: gomnd
 	// DropNotActive - drop is no longer active
 	ErrDropNotActive = sdkerrors.Register(ModuleName, 23, "drop not active") // nolint: gomnd
+	// ErrOrderCanceled - order is already canceled
+	ErrOrderCanceled = sdkerrors.Register(ModuleName, 24, "order already canceled") // nolint: gomnd
 )