Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #3 #4

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Fix issue #3 #4

merged 2 commits into from
Sep 14, 2020

Conversation

daquexian
Copy link
Member

@daquexian daquexian commented Sep 7, 2020 •
edited
Loading

It fixes issue #3 by adding a unsqueeze op after the scalar bias

@linkerzhang
Copy link
Member

will you also add test cases to cover it?

@askhade
Copy link

askhade commented Sep 10, 2020

Please add description for your PR

@daquexian
Copy link
Member Author

will you also add test cases to cover it?

@linkerzhang Sure. I have added it.

@daquexian
Copy link
Member Author

Please add description for your PR

@askhade Done

@daquexian daquexian mentioned this pull request Sep 12, 2020
Open
@linkerzhang linkerzhang merged commit 752b089 into onnx:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linkerzhang linkerzhang linkerzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daquexian @linkerzhang @askhade