-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onnx optimizer init #2
Conversation
After discussion with @linkerzhang, I renamed onnx_opt to onnxoptimizer |
@daquexian thank you very much for making the change. are you going to setup CI for this repo please? |
@linkerzhang Thanks for your advice! I have copied the azure pipeline ci yaml files from onnx/onnx repo and made some necessary changes for onnx/optimizer Could you please set it up so that we can see whether the ci passes? Thanks! |
I guess I don't have such access neither right now. |
Can you specify what you are looking for? Azure Pipelines is enabled for all repos under ONNX. I would also recommend using GitHub Actions |
@prasanthpul I just noticed that there is no pipeline yaml in onnx/optimizer repo now since this PR has not been merged. So your help will be needed after this PR is merged :) @linkerzhang I will setup and test the ci in my own repo (daquexian/optimizer) for now |
@linkerzhang The ci has passed: https://dev.azure.com/daquexian/onnx-optimizer/_build |
@daquexian : Please prefer github actions for CIs. Azure pipelines and github actions are very similar and underneath they are based on same stack I believe... With github actions there is 1 layer less to interact. If you have a working azure pipeline CI then moving it to github actions should be trivial. |
I'll switch to github actions when I have time |
@askhade I have replaced azure pipelines with github actions in #7. |
Related issue: #1
This PR contains the separate onnx optimizer library, in detail:
An
onnxoptimizer
(not sure whether it is a good name) package will be installed after runningpip3 install -e .
.pytest
passes.