Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ElideKrnlGlobalConstants #2740

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

tungld
Copy link
Collaborator

@tungld tungld commented Mar 4, 2024

ElideKrnlGlobalConstants pass is obsoleted, and was replaced by MLIR elide flags. So remove it in this patch.

Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tungld tungld merged commit 9202207 into onnx:main Mar 5, 2024
8 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #14269 [push] Clean up ElideKrnlGlobal... started at 19:37

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #14298 [push] Clean up ElideKrnlGlobal... started at 20:37

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #14269 [push] Clean up ElideKrnlGlobal... passed after 1 hr 10 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #14298 [push] Clean up ElideKrnlGlobal... passed after 1 hr 37 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #13295 [push] Clean up ElideKrnlGlobal... started at 02:55

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #13295 [push] Clean up ElideKrnlGlobal... passed after 2 hr 15 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants