Add Shape op verifier #1711
Merged
Add Shape op verifier #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Lassen <[email protected]>
Signed-off-by: Philip Lassen <[email protected]>
tungld
approved these changes
Sep 20, 2022
|
Jenkins Linux ppc64le Build #6708 [push] Add Shape op verifier (#... started at 02:53 |
|
Jenkins Linux s390x Build #7659 [push] Add Shape op verifier (#... started at 02:51 |
|
Jenkins Linux amd64 Build #7644 [push] Add Shape op verifier (#... started at 01:51 |
|
Jenkins Linux amd64 Build #7644 [push] Add Shape op verifier (#... passed after 1 hr 7 min |
|
Jenkins Linux ppc64le Build #6708 [push] Add Shape op verifier (#... passed after 1 hr 38 min |
|
Jenkins Linux s390x Build #7659 [push] Add Shape op verifier (#... passed after 1 hr 46 min |
sstamenova
pushed a commit
to sstamenova/onnx-mlir
that referenced
this pull request
Sep 21, 2022
* Add Shape op verifier Signed-off-by: Philip Lassen <[email protected]> Signed-off-by: Stella Stamenova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think the attributes provided constituted a valid shape op instance.
But it should have failed more gracefully. I've added a verifier for shape op. As well as a test for it.
I also have updated the docs to reflect that lowering doesn't support slices.
Closes #1710
Thanks for flagging this for me @tungld