feat: track service ttl and lastSeen #55
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential solution for #25
Currently the browser does not respect the TTL of the services it discovers.
Additionally, the only way to forget a service is for the remote to report that it is stopping, or to manually dispose and restart the browser.
This can easily lead to leaking memory, as some services do not report stopping, and there are many scenarios where they cannot (such as unclean shutdown or loss of network/power).
This attempts to resolve this is a non-breaking fashion.
To achieve this, we now track the ttl of the PTR record, and the last time we received the PTR record.
The user can then call an
expire
method, to trigger a check and purge of any services which have passed their ttl.This makes an assumption that the ttl of each record is the same. If this is not the case, this could behave 'wrong' but I suspect that the current discovery could also get confused by that.