Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put seek graph alongside create game on desktop screens #2868

Conversation

GreenAsJade
Copy link
Contributor

Fixes

  • the list that people are looking for being way down the bottom.
  • seek-graph being curiously wide and space-consuming

Proposed Changes

  • Put seek-graph alongside create game form for wide screens
    -- Note the deliberate choice to make the row containing these two wider than normal
    --- So that Create Game is the focus, and can be a nice width.

Copy link

github-actions bot commented Nov 22, 2024

Uffizzi Preview deployment-58494 was deleted.

@anoek
Copy link
Member

anoek commented Nov 22, 2024

It's hanging off in a weird way over here:

image

I'm not sure how to shrink that up nicely. I do find myself wondering if we should revert the change to have the game creation options on the left, and instead have two buttons, one to create a custom game that pops open the open challenge modal like we used to have, and another to create a custom computer game like we used to have. That'd probably free up enough space for the graph. Perhaps a third to challenge a friend with a search field, it seems doing that isn't the easiest right now, it might be worth turning that space into space to launch the various challenge modals we have.

I'm also not sure how useful the graph is anymore these days, perhaps we just get rid of it.

@BHydden
Copy link
Collaborator

BHydden commented Nov 22, 2024

While you're playing with this page, the filter section doesn't like vertical mobile layout.

Screenshot_20241123

@GreenAsJade
Copy link
Contributor Author

TLDR: I agree, iet's get rid of it.


I "hung it off the side" there on purpose :)

My feeling was "who says this has to be constrained here?"

The Create Game form is the main thing, the seek graph is "off to the side".

If it looks wierd, I'd be more inclined to try to make it look more "on purpose" than "squeeze it up". The aspect ratio of the graph is kinda "right", it doesn't work to square it (or to stretch it)

@GreenAsJade
Copy link
Contributor Author

I couldn't quite come at getting rid of it, so I gave it a toggle in #2871 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants