feat(quickopen): Add binds to open in splits to Quick Open #3733
Conversation
src/Model/GlobalCommands.re
Outdated
| let selectHorizontal = | ||
| register( | ||
| "list.selectHorizontal", | ||
| ListSelect({ | ||
| direction: Oni_Core.SplitDirection.Horizontal, | ||
| }), | ||
| ); | ||
| let selectVertical = | ||
| register( | ||
| "list.selectVertical", | ||
| ListSelect({ | ||
| direction: Oni_Core.SplitDirection.Vertical({shouldReuse: false}), | ||
| }), | ||
| ); | ||
| let selectNewTab = | ||
| register( | ||
| "list.selectNewTab", | ||
| ListSelect({ | ||
| direction: Oni_Core.SplitDirection.NewTab, | ||
| }), | ||
| ); |
There was a problem hiding this comment.
Awesome! Thanks for adding these 🎉
src/Model/State.re
Outdated
| bind( | ||
| ~key="<C-v>", | ||
| ~command=Commands.List.selectVertical.id, | ||
| ~condition="listFocus" |> WhenExpr.parse, | ||
| ), |
There was a problem hiding this comment.
The only concern I have here is that the Control+V keybinding would conflict with paste on Windows/Linux (ie, regressing #2308)
A couple ideas:
- We could use
Control+Shift+Vfor opening in vertical tab - We could use the
Shift+CRkeybinding for vertical, andControl+Tfor new tab
src/Model/GlobalCommands.re
Outdated
| let selectNewTab = | ||
| register( | ||
| "list.selectNewTab", | ||
| ListSelect({ | ||
| direction: Oni_Core.SplitDirection.NewTab, |
There was a problem hiding this comment.
Looks like this will address #2232 🎉
src/Model/State.re
Outdated
| bind( | ||
| ~key="<C-s>", | ||
| ~command=Commands.List.selectHorizontal.id, | ||
| ~condition="listFocus" |> WhenExpr.parse, | ||
| ), |
There was a problem hiding this comment.
This also conflicts with the save keybinding, but I think this one is OK - understandable that save wouldn't occur when the quickmenu is up.
|
Did a quick survey of some common binds for this sort of thing and updated them accordingly, but with Shift-enter as vertical open by default since we use c-v as copy. That said, obviously if a user wanted to swap they could just do something like: { "key": "<C-s>", "command": "list.selectHorizontal", "when": "listFocus" }The only other thing I wanted to check here is if the command names are okay. VSCode has no equivalent, so wasn't sure if they should be prefaced with |
Awesome! Thanks for looking into this @CrossR . Looks good to me.
Hmm, good point - VSCode does have a |
__Issue:__ Using `:tabnew` or `:tabedit` (or Control+T in #3733) would create a new vim-style layout tab, but there'd be an extra 'editor tab' in the initial window split. __Defect:__ There was an extra copy/create of the editor in the layout code. __Fix:__ Remove extraneous copy __Todo:__ - [x] Add regression test
|
Swapped the names, added some basic docs, just waiting for the CI to be happy then I'll squash/merge. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Sorry about the build issues; the CentOS build failure looks unrelated. I'll override and merge. Thanks for the awesome contribution @CrossR ! |
Fix #564
Fix #2232
A rough first pass, but adds default bindings for selecting items from the quick open to open in current/vertical/horizontal/new tab.
Binds aren't finalised, so some input there would be nice (Ctrl-s and Ctrl-v are the defaults in Fzf in vim which is why I went with them).