Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Elm as language supported? I am getting error with it. #2640

Closed
segmentationfaulter opened this issue Oct 28, 2020 · 3 comments · Fixed by #2999
Closed

Is Elm as language supported? I am getting error with it. #2640

segmentationfaulter opened this issue Oct 28, 2020 · 3 comments · Fixed by #2999
Labels
A-extension Area: Extension/plugin integration, vscode or VimL bug Something isn't working L-elm Language: Elm

Comments

@segmentationfaulter
Copy link

I have tried installing this elm extension and it failed to load as shown in the screenshot. Is Elm as a language not supported?

elm-error

@bryphe
Copy link
Member

bryphe commented Oct 28, 2020

Hi @segmentationfaulter ,

I just installed the elm extension to double-check - and it seems to be working for me:

elm-language

(At least - hover via gh, go-to definition via gd, basic completion, etc).

The error message suggests that maybe the installation wasn't successful - the request package referenced in the error message should be bundled with the extension.

My recommendation would be to try uninstalling and reinstalling the plugin - you could run this command:

oni2 --uninstall-extension elmTooling.elm-ls-vscode

And then:

oni2 --install-extension elmTooling.elm-ls-vscode

Once it successfully installs - try opening Onivim 2 in the directory of your project. Hopefully that error should go away on reinstall.

@bryphe bryphe added A-extension Area: Extension/plugin integration, vscode or VimL bug Something isn't working L-elm Language: Elm labels Oct 28, 2020
@segmentationfaulter
Copy link
Author

It seemed to be working after installing and uninstalling to the extent you have mentioned above, but I cannot see diagnostic messages. Can you see diagnostic messages with you? Thanks for the help though.

@bryphe
Copy link
Member

bryphe commented Jan 15, 2021

Troubleshooted the diagnostics today - it seems the diagnostics are run on save, but we weren't sending the appropriate textDocument/didSave event, so diagnostics would never run.

With that implemented, we now get diagnostics:
image

bryphe added a commit that referenced this issue Jan 16, 2021
__Issue:__ Diagnostics weren't displaying in the elm extension

__Defect:__ Diagnostics are computed on save, but we weren't sending the appropriate event to the extension host to let it know when a save occurred.

__Fix:__ Notify extension host on save

With that, we get diagnostics:
![image](https://user-images.githubusercontent.com/13532591/104788805-02225b80-5748-11eb-819b-2f5dc06b2b6d.png)

Fixes #2640 
Related #1058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-extension Area: Extension/plugin integration, vscode or VimL bug Something isn't working L-elm Language: Elm
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants