Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabn and tabp do not wrap around #2230

Closed
mabuchner opened this issue Aug 5, 2020 · 0 comments · Fixed by #2317
Closed

tabn and tabp do not wrap around #2230

mabuchner opened this issue Aug 5, 2020 · 0 comments · Fixed by #2317
Labels
A-vim Area: Vim/modal editing bug Something isn't working

Comments

@mabuchner
Copy link

mabuchner commented Aug 5, 2020 •
edited
Loading

In vim if the first tab is active and I type :tabp<cr> or gT, then the last tab will get activated.

A similar thing happens, if the last tab is active and I type :tabn<cr> or gt, then the first tab will get activated.

This currently doesn't work in Oni2. If the first (layout) tab is active and I type :tabp<cr> or gT, then nothing will change. Same for the last tab with :tabn<cr> and gt.
@bryphe bryphe added A-vim Area: Vim/modal editing bug Something isn't working labels Aug 7, 2020
@bryphe bryphe mentioned this issue Aug 18, 2020
Merged
bryphe added a commit that referenced this issue Aug 18, 2020
@bryphe
fix(layout/#2230): Tab wrapping (#2317)
fc51cfc 
__Issue:__ As described in #2230 - the tab movement commands (`:tabn`, `:tabp`, `gt`, `gT`) don't wrap

__Fix:__ Update the logic to wrap instead of clamp

Fixes #2230
@bryphe bryphe mentioned this issue Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-vim Area: Vim/modal editing bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(layout/#2230): Tab wrapping onivim/oni2
2 participants
@mabuchner @bryphe