This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 299
[WIP] Feature/token color trie #2621
Open
akinsho
wants to merge
38
commits into
onivim:master
Choose a base branch
from
akinsho:feature/token-color-trie
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so it appears in documentation dropdown
update affected tests
add public keyword to as token color function of trieNode
Codecov Report
@@ Coverage Diff @@
## master #2621 +/- ##
========================================
+ Coverage 45.3% 45.4% +0.1%
========================================
Files 361 362 +1
Lines 14571 14678 +107
Branches 1912 1930 +18
========================================
+ Hits 6601 6665 +64
- Misses 7746 7785 +39
- Partials 224 228 +4
Continue to review full report at Codecov.
|
as this occupies ++ space in memory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #2565 this PR introduces a
trie
data structure to handle tokens read in from the theme, inspired by thisvscode strategy
The reasoning being in summary, a trie allows us to resolve the complicated inheritance like pattern for tokens which is how textmate/vscode reads in themes e.g. if string is =>
{ color: red, style: italic }
and string.quoted is =>{ color: blue }
, then when read out of the tree the settings for this will be{ color: blue, style: italic // inherited }
(simplification * 2)Outstanding: