Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Fix #2149 - Part 1 - Add configuration setting for explorer refresh #2154

Merged
merged 3 commits into from
May 1, 2018

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Apr 30, 2018

Issue: There can be a performance degradation when upgrading from Oni 0.3.2 -> Oni 0.3.3 due to the way we watch the file system / update the UI in response to it.

Fix: We'll gate the 'autoRefresh' behavior behind a flag - explorer.autoRefresh, which defaults to false. We'll enable an explicit refresh gesture with the explorer.refresh command, bound to <C-r>.

@bryphe
Copy link
Member Author

bryphe commented Apr 30, 2018

Note that this doesn't completely address #2149 - we should also hook up the oni.exclude files configuration to work with the explorer file watching (and investigate other ways to optimize the perf as @Akin909 mentioned).

@codecov
Copy link

codecov bot commented Apr 30, 2018

Codecov Report

Merging #2154 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2154      +/-   ##
==========================================
- Coverage   37.04%   37.04%   -0.01%     
==========================================
  Files         293      293              
  Lines       11979    11980       +1     
  Branches     1582     1582              
==========================================
  Hits         4438     4438              
- Misses       7289     7290       +1     
  Partials      252      252
Impacted Files Coverage Δ
browser/src/App.ts 6.75% <0%> (ø) ⬆️
browser/src/Input/KeyBindings.ts 2.22% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb0a76...920481f. Read the comment docs.

@bryphe bryphe merged commit e445e20 into master May 1, 2018
@badosu badosu deleted the bryphe/2149.1/add-autorefresh-setting branch May 1, 2018 02:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant