Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Refactor FileIcon to styled-components #1980

Merged
merged 1 commit into from
Mar 30, 2018

Conversation

manu-unter
Copy link
Collaborator

This is one of several smaller upcoming PRs with the goal to replace all remaining .less files with styled-components.

  • Move the animation code from Tabs.less into FileIcon.tsx
  • Replace additionalClassNames prop with the (also more restrictive, but better encapsulated) playAppearAnimation

@codecov
Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #1980 into master will increase coverage by 0.02%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1980      +/-   ##
==========================================
+ Coverage   35.43%   35.46%   +0.02%     
==========================================
  Files         276      276              
  Lines       10617    10620       +3     
  Branches     1344     1343       -1     
==========================================
+ Hits         3762     3766       +4     
+ Misses       6670     6669       -1     
  Partials      185      185
Impacted Files Coverage Δ
browser/src/UI/components/Tabs.tsx 33.33% <ø> (ø) ⬆️
browser/src/Services/FileIcon.tsx 57.14% <45.45%> (+20.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eca2f3e...35406d9. Read the comment docs.

Copy link
Member

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great 👍

@akinsho akinsho merged commit 9b8aa11 into onivim:master Mar 30, 2018
@bryphe
Copy link
Member

bryphe commented Mar 30, 2018

👍 Thanks for splitting this out, @cryza !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants