Feature/add search icon commandline #1230
Conversation
also add icon - file icon atm ?alternatives
Components now render in the same layer and can be positioned similarly if both present or interchangeably if one options is disabled
Also only render overlay if both elements present
using whitespace: pre-wrap from one of see facebook/react#4134 html auto removes trailing white space breaking the cursor's position functionality
to ensure commandline and wild menu have same width
…h-icon-commandline
|
Cool idea! Thanks for putting this together, @Akin909 ! Code change looks good to me - appreciate you putting it behind an experimental flag. I'm going to push out a new release next week, will be awesome to start getting feedback on these 👍 The search next and search previous icons look great. I'm not sure about the |
|
Just checked the tests - passing locally again, so I'll go ahead and bring this in. Thanks for the contribution! 😄 I'm working on a change to get the console logs a different way (it seems in some cases we don't get any logs, so hopefully this change will fix that, and let us get to the next level of investigation). Sorry about all the test issues. |
@bryphe as per discussion in #1191 I've also added a config managed option to render an icon in place of the first character. It's off by default and under the
experimental.commandline.icons. There's currently an icon for:?and
/.