Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Upgrade TypeScript to 2.4.1 #519

Closed
bryphe opened this issue Jul 5, 2017 · 3 comments · Fixed by #601
Closed

Upgrade TypeScript to 2.4.1 #519

bryphe opened this issue Jul 5, 2017 · 3 comments · Fixed by #601
Assignees
@bryphe
Labels
chore
Milestone
Backlog

Comments

@bryphe
Copy link
Member

bryphe commented Jul 5, 2017

Looks like there were several breaking changes in this upgrade (lots of compilation errors to be fixed). These will need to be manually addressed.
@bryphe bryphe added the chore label Jul 5, 2017
@bryphe bryphe added this to the Backlog milestone Jul 5, 2017
@keforbes
Copy link
Collaborator

The compilation errors are actually microsoft/TypeScript#16772, which can be resolved by also updating ts-loader.
So typescript: 2.4.1 and ts-loader: 2.2.2. I was going to submit a Pull Request with this fix but Oni currently doesn't build due to an unrelated error:

ERROR in ./browser/src/Plugins/Api/Oni.ts
Class 'Oni' incorrectly implements interface 'Api'

I didn't want to submit a Pull Request with a broken build so I decided to just document the fix here.

@bryphe
Copy link
Member Author

bryphe commented Jul 12, 2017

Thanks for the investigation, @keforbes ! That helps a lot - I didn't see that issue. I'll take a shot at it and see what's going on with that error.

@bryphe bryphe self-assigned this Jul 12, 2017
@bryphe bryphe mentioned this issue Jul 12, 2017
Merged
bryphe pushed a commit that referenced this issue Jul 12, 2017
Fix #519 - Upgrade to TypeScript 2.4.1 (#535)
f3ed138 
* Bump typescript and ts-loader versions

* Update 
egisterLanguageService to be consistent between the Oni implementation and the definition

* Fix typing in Oni and LanguageClient

* Temporarily use 'any' type

* Change first instance of any -> React.CSSProperties

* Fix any typing

* Fix typing in QuickInfo
@bryphe bryphe reopened this Jul 21, 2017
@bryphe
Copy link
Member Author

bryphe commented Jul 21, 2017

Temporarily reverting this change, because it looks like there is a regression or a change in the completion behavior after < in .tsx files.

For example, if I'm typing in NeovimSurface.tsx:

export class NeovimSurface extends React.PureComponent<R|

I'd expect completion to pop open. However, it seems that at least this case and a few others are broken after upgrading to TypeScript 2.4.1, and the completion dialog does not open in this case.

Need to check:

  • Is this an open / active issue in the typescript github repo?
  • Does it only impact tsx files, or does it also impact generics in ts files?
  • Did it start in 2.3.x or 2.4.x?

bryphe pushed a commit that referenced this issue Jul 21, 2017
Revert "Fix #519 - Upgrade to TypeScript 2.4.1 (#535)"
e7cf071 
This reverts commit f3ed138.
@bryphe bryphe mentioned this issue Jul 21, 2017
Merged
@bryphe bryphe closed this as completed in a8f731c Jul 21, 2017
@bryphe bryphe reopened this Aug 11, 2017
@bryphe bryphe mentioned this issue Aug 11, 2017
Merged
bryphe pushed a commit that referenced this issue Aug 11, 2017
Fix #519 - Upgrade typescript 2.4.2 (#601)
933cb35 
* Bring back TS upgrade

* Bump typescript to 2.4.2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bryphe bryphe

Labels
chore
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix #519 - Upgrade typescript 2.4.2 onivim/oni
2 participants
@keforbes @bryphe