Fix creating pager range

[serieznyi]

Pager always create count pages equals value of PagerAwareViewData::maxPages.
So I am fix it.
I use logic from this function in repository jasongrimes/php-paginator

UPDATE 1
I use modified code of @JanTvrdik

[JanTvrdik]

This BTW what we use

public function getPages(): array
{
	$start = 1;
	$numAdjacents = (int) floor(($this->maxPages - 1) / 2);

	if ($this->currentPage - $numAdjacents < $start) {
		$begin = $start;
		$end = min($this->numPages, $this->maxPages);

	} elseif ($this->currentPage + $numAdjacents > $this->numPages) {
		$begin = max($start, $this->numPages - $this->maxPages + 1);
		$end = $this->numPages;

	} else {
		$begin = $this->currentPage - $numAdjacents;
		$end = $this->currentPage + $numAdjacents;
	}

	return range($begin, $end, 1);
}

[serieznyi]

@JanTvrdik Yours variant more shortly ))

[serieznyi]

@JanTvrdik I try your code. It is good.
By I think we need always show first and last pages.
So for this we need little change last part of code

return array_unique(array_merge(
            [1],
            range($begin, $end, 1),
            [$this->numPages]
        ));

and we get that

I try use your code in PR

[serieznyi]

I think this changes need be in 2.1 but my branch based on master
My wrong.
I can recreate branch later if this changes be merged

[saimaz]

Looks like a good fix. Please rebase you PR to 2.1 branch. I have changed the base in the PR, you only need to rebase and push the changes.

[JanTvrdik]

@serieznyi We solve the „always display first page“ problem in template

{% set paginationRoute = app.request.attributes.get('_route') %}
{% set paginationParams = filters.pagination.getUrlParameters() %}
{% set pages = filters.pagination.pages %}

<ul>
	{% if pages|first != 1 %}
		<li><a href="{{ ongr_paginate_path(paginationRoute, 1, paginationParams) }}">1</a></li>
		<li>&hellip;</li>
		{% set pages = pages|slice(2) %}
	{% endif %}

	{% for page in pages %}
		<li class="{% if page == filters.pagination.getCurrentPage %}is-active{% endif %}">
			<a href="{{ ongr_paginate_path(paginationRoute, page, paginationParams) }}">{{ page }}</a>
		</li>
	{% endfor %}
</ul>

[serieznyi]

@saimaz with rebase my branch contains not may commits. So i do cherry-pick.
Also you need what while I check test.
For some reason tests not run in travis

[serieznyi]

@saimaz why travic-ci fail on prepare tests environment? What I need to do?

[serieznyi]

@saimaz I read Travic-CI docs and understand what a problem.
You need update or set GITHUB_COMPOSER_AUTH env variable on https://travis-ci.org/ongr-io/FilterManagerBundle/settings page

[saimaz]

Thanks @serieznyi for the changes. I fixed Travis issues. Lets see if there will be any errors.

[saimaz]

Ok, seems like token fix didn't help. There is no java 8 anymore in the current travis image we are using. So I changed the java version to 9 in the 2.1 branch. Apparently one test is failing, I will take a look whats wrong with it. If someone could help on this I would appreciate.

[serieznyi]

@saimaz I create issue and PR for problem with tests. I be wait when you merge tests fix and when I merge 2.1 with new changes in current PR

[saimaz]

Thanks @serieznyi for the fixes it helped me a lot! Appreciate this. You can rebase now with 2.1 branch and I could merge this as well and then release a patch version.

[serieznyi]

@saimaz maybe i simple merge origin/2.1 in my feature branch and you use squash merge if all ok?

[saimaz]

Sure I could squash merging the PR, but travis still freaks out with errors :(

[serieznyi]

@saimaz I know about tests fail. I try fix it in few days

[serieznyi]

@saimaz tests fixed. I think what you need see my code and analyse what I do.

[saimaz]

Why did you set max pages to 3 instead of 2?

[serieznyi]

@saimaz Because I throw exception then maxPages less 3.
Why? Because I always return first and last pages from getPages method. And if user set maxPages equal 2 or less then he see only first and last page.

Also I have some errors in my logic and I try fix it.

[serieznyi]

@saimaz I fix my logic. You can check it. Try tests

[serieznyi]

@saimaz I replace throwing exception on default minimum value because I afraid that my changes crash somebody app.

[serieznyi]

Anybody can watch my PR? Please )

[saimaz]

I'm checking it. Looks quite good. Will test it and merge it quite soon ;) Thanks for the PR!

[11mb]

quite soon? ;)

[saimaz]

yep ;)

[khusseini]

How come this was only merges into 2.1? Isn't this bug relevant for all branches?